97621[BUGFIX] Sync page wizard fields before reading the form values
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 1
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/21/97621/1 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/21/97621/1 && git cherry-pick FETCH_HEAD
Review
-
Code review CR -1 Needs a vote
- Oli Bartsch -1
-
Verified V 0 Needs a vote
- core-ci +1 CI
Merge conflicts 3
Issues 1
Files 4
- Build/Sources/TypeScript/backend/page-wizard/steps/form-engine-step.ts2+6 −0
- Build/tests/playwright/e2e/page-wizard/page-creation-via-create-new-button.spec.ts+27 −0
- Build/tests/playwright/fixtures/page-wizard.ts+7 −0
- typo3/sysext/backend/Resources/Public/JavaScript/page-wizard/steps/form-engine-step.js+1 −1
Review log 23
-
Andreas Nedbal uploaded patch set 1 11/13/26, 16:13
-
Oli Bartsch commented on patch set 1 CR -1 11/13/26, 18:07
form-engine-step.ts:55Unresolvedplease only sync fields that are really out of sync instead of calling `updateInputField()` for every field. For a `password` field, Next -> Back -> Next without touching it restores the hidden value, the visible field shows `********`, and the sync then overwrites the hidden value with that placeholder, so the page is saved with the literal `********`. Skipping the field when `visible.value === formatByEvals(config, hidden.value)` avoids this, ideally as a small helper in `FormEngineValidation` so the step does not re-implement FormEngine internals. -
core-ci voted on patch set 1 V +1 11/13/26, 18:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114360
form-engine-step.ts:54Unresolved