Review main Ready for review

97621[BUGFIX] Sync page wizard fields before reading the form values

Andreas Nedbal CR -1 V 0 Easy +41 −1 updated 11/13/26, 18:44

Commit message

The page wizard reads the values of its FormEngine step from the hidden
fields of the form. These only receive the value of the visible input
in a "change" handler. If the wizard advances before that event fired,
for example because the input was filled without losing focus, the
hidden field is still empty. FormEngineStep::getValue() then drops it
as an empty value, so the page is created without the typed title.

FormEngineStep::getValue() now updates the hidden field of every
visible input via FormEngineValidation.updateInputField() before it
reads the form data. The method only writes if the value changed, so
already synchronized fields are not touched.

A Playwright test advances the wizard without a "change" event on the
title field and asserts that the created page carries the title.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 1
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/21/97621/1 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/21/97621/1 && git cherry-pick FETCH_HEAD

Review

  • Code review CR -1 Needs a vote
    • Oli Bartsch -1
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 3

Issues 1

Files 4

Review log 23

  1. Andreas Nedbal uploaded patch set 1 11/13/26, 16:13

  2. Oli Bartsch commented on patch set 1 CR -1 11/13/26, 18:07

    form-engine-step.ts:54 Unresolved

    please iterate `TYPO3.FormEngine.Validation.inputSelector` and take the field name from the params (as `initializeInputFields()` does) instead of `[data-formengine-input-name]`. The current selector also matches checkboxes, selects, the readonly translated slug input and custom renderTypes, and `updateInputField()` throws a `TypeError` on elements without a named field, which leaves the editor stuck on the step.

    form-engine-step.ts:55 Unresolved

    please only sync fields that are really out of sync instead of calling `updateInputField()` for every field. For a `password` field, Next -> Back -> Next without touching it restores the hidden value, the visible field shows `********`, and the sync then overwrites the hidden value with that placeholder, so the page is saved with the literal `********`. Skipping the field when `visible.value === formatByEvals(config, hidden.value)` avoids this, ideally as a small helper in `FormEngineValidation` so the step does not re-implement FormEngine internals.
  3. core-ci voted on patch set 1 V +1 11/13/26, 18:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114360