Review 14.3 Merged

97638[BUGFIX] Avoid undefined array key in HrefLangGenerator

Benni Mack CR +2 V +2 Easy +31 −5 updated 11/14/26, 11:17

Commit message

If all languages of a site are disabled, the language menu
processor does not provide the "languagemenu" key, which led
to PHP warnings when generating hreflang tags, e.g. while
previewing such a site as a backend user.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 69

  1. Benni Mack commented on patch set 1 11/14/26, 07:54

    Cherry Picked from branch main.
  2. Benni Mack rebased onto patch set 2 11/14/26, 09:15

  3. Benni Mack rebased onto patch set 3 11/14/26, 10:11

  4. core-ci voted on patch set 1 V -1 11/14/26, 10:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114423

  5. core-ci voted on patch set 3 V -1 11/14/26, 10:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114429

  6. Benni Mack commented on patch set 4 V -1 11/14/26, 11:05

    Published edit on patch set 3.
  7. core-ci voted on patch set 4 V +1 11/14/26, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114439

  8. Benni Mack voted on patch set 4 CR +2 V +2 11/14/26, 11:17

  9. Benni Mack merged patch set 5 11/14/26, 11:17