Review main Ready for review

97668[TASK] Fix hidden content check in publish tests

Sebastian Mendel CR 0 V 0 Easy +14 −6 updated 11/14/26, 22:35

Commit message

After publishing, the hidden content element is hidden in live.
The frontend requests of the hideContent tests in WorkspacesPublish
and WorkspacesPublishAll pass no workspace id, so the
testing-framework BackendUserHandler keeps the backend user at
workspace id -99. That id is no workspace: PageRepository adds the
hidden constraint only for workspace 0, and versionOL() skips ids
below 1. The frontend renders the hidden element, and the tests
expect that.

Request the live workspace explicitly and assert that the hidden
element is not rendered, as the WorkspacesModify tests do for the
same scenario in a workspace. A visible record on each requested
page makes sure the page itself was rendered.

The adjusted tests pass with the current testing-framework and with
https://github.com/TYPO3/testing-framework/pull/536, which defaults
the backend user to the live workspace and breaks the old
expectation.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 3
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/68/97668/3 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/68/97668/3 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 3

Issues 1

Files 2

Review log 36

  1. Sebastian Mendel uploaded patch set 1 11/14/26, 22:02

  2. core-ci voted on patch set 1 V +1 11/14/26, 22:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114492

  3. Sebastian Mendel uploaded patch set 2 V +1 11/14/26, 22:15

  4. core-ci voted on patch set 2 V +1 11/14/26, 22:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114493

  5. Sebastian Mendel uploaded patch set 3 11/14/26, 22:26

    Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  6. core-ci voted on patch set 3 V +1 11/14/26, 22:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114494