Review main Work in progress

97669[BUGFIX] Keep SVG crop anchored at the top left corner

Benni Mack CR 0 V 0 Normal +31 −23 updated 11/15/26, 07:56

Commit message

A crop variant starting at x=0/y=0, e.g. the left half of an
SVG, was ignored and the original, uncropped SVG was delivered.

ImageProcessingInstructions::fromProcessingTask() passed the
dimensions of the crop area as the incoming image dimensions to
fromCropScaleValues(). Its check that drops a crop area covering
the whole image thus matched every crop anchored at the top left
corner, and SvgImageProcessor fell back to the original file.

The dimensions of the source file are now handed in, as all other
callers of fromCropScaleValues() already do.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 1
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/69/97669/1 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/69/97669/1 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 4

Issues 1

Files 3

Review log 23

  1. Benni Mack uploaded patch set 1 11/15/26, 07:50

  2. Benni Mack marked it work in progress 11/15/26, 07:52

  3. core-ci voted on patch set 1 V +1 11/15/26, 07:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114512