Review main Merged

97766[BUGFIX] Provide LinkService via container in softref parser test

Benni Mack CR +2 V +2 Easy +1 −1 updated 11/17/26, 20:05

Commit message

LinkService no longer implements SingletonInterface, so registering
it with GeneralUtility::setSingletonInstance() in
TypoLinkTagSoftReferenceParserTest fails with a TypeError. The test
now sets LinkService in the container, as the other tests in the
class do.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 3

Files 1

Review log 34

  1. Benni Mack uploaded patch set 1 11/17/26, 19:49

  2. core-ci voted on patch set 1 V +1 11/17/26, 20:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114785

  3. Benni Mack voted on patch set 1 CR +2 V +2 11/17/26, 20:05

  4. Benni Mack merged patch set 2 11/17/26, 20:05