#111467Free further core services from SingletonInterface
Description
Follow-up to #110578 and #111403.
SingletonInterface only turns a class into a shared and public service, so GeneralUtility::makeInstance() can reach it. Sharing is the container default anyway. The marker is dropped from further Core classes where this is the only effect:
- TYPO3\CMS\Backend\Routing\UriBuilder
- TYPO3\CMS\Core\EventDispatcher\EventDispatcher
- TYPO3\CMS\Core\LinkHandling\LinkService
- TYPO3\CMS\Core\Locking\LockFactory
- TYPO3\CMS\Core\Resource\ResourceFactory
- TYPO3\CMS\Core\TimeTracker\TimeTracker
- TYPO3\CMS\Extbase\Persistence\Generic\PersistenceManager
- TYPO3\CMS\Extbase\Reflection\ReflectionService
Classes that are fetched by class name are declared public explicitly, so makeInstance() call sites keep working. Tests that substituted them via setSingletonInstance() hand the substitute to a container instead.
Reviews 2
History 13
-
Gerrit Code Review pushed patch set 1 for main to change 97693 status
NewUnder Review <span data-processor="relativetime" data-value="2026-11-16T16:11:41+00:00" > 11/16/26, 16:11 </span> -
Gerrit Code Review pushed patch set 2 for main to change 97693 <span data-processor="relativetime" data-value="2026-11-17T11:05:17+00:00" > 11/17/26, 11:05 </span>
-
Benni Mack commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2026-11-17T18:40:12+00:00" > 11/17/26, 18:40 </span>
Applied in changeset commit:e83f40087b15008bb68ad56d5bc12560643d717d.