Review 14.3 Merged

97768[BUGFIX] Let the honeypot render its own attributes

Georg Ringer CR +2 V +2 Normal +104 −1 updated 11/17/26, 21:07

Commit message

The honeypot partial spent additionalAttributes on a literal
aria-hidden, so the three editors of the element writing into
fluidAdditionalAttributes were discarded. It now reads that property
and carries the ARIA state in the ViewHelper's aria argument, as every
other frontend partial does, and autocomplete off becomes a default so
a form filler no longer trips the HoneypotValidator. The
renderAsHiddenField branch stays untouched, because an input of type
hidden must not carry autocomplete.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 6

Review log 46

  1. Georg Ringer commented on patch set 1 11/17/26, 20:32

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 11/17/26, 20:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114793

  3. Georg Ringer uploaded patch set 2 V -1 11/17/26, 20:54

  4. core-ci voted on patch set 2 V +1 11/17/26, 20:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114794

  5. Georg Ringer voted on patch set 2 CR +2 V +2 11/17/26, 21:07

  6. Georg Ringer merged patch set 3 11/17/26, 21:07