Review 14.3 Merged

97787[TASK] Quote forwarded arguments in runTests.sh

Benjamin Kott CR +2 V +2 Easy +12 −15 updated 11/18/26, 10:56

Commit message

The e2e suites, lintTypescript and phpstanGenerateBaseline passed the
remaining arguments on as one string, so word splitting broke
--grep "a pattern" into several arguments and Playwright read the
extra words as file filters. The commands are now built as arrays,
or get the arguments as positional parameters where a shell is needed.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
  • Verified V +2 Done
    • Benjamin Kott +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Benjamin Kott commented on patch set 1 11/18/26, 10:35

    Cherry Picked from branch main. The following files contain Git conflicts: * Build/Scripts/runTests.sh
  2. core-ci voted on patch set 1 V -1 11/18/26, 10:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114845

  3. Benjamin Kott uploaded patch set 2 V -1 11/18/26, 10:37

  4. Benjamin Kott commented on patch set 2 11/18/26, 10:37

    This change is ready for review.
  5. core-ci voted on patch set 2 V +1 11/18/26, 10:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114851

  6. Benjamin Kott voted on patch set 2 CR +2 V +2 11/18/26, 10:56

  7. Benjamin Kott merged patch set 3 11/18/26, 10:56