Review 14.3 Merged

97789[TASK] Guard nullable values in TypeScript

Benjamin Kott CR +2 V +2 Hard +308 −277 updated 11/18/26, 17:33

Commit message

Properties initialised with null now declare it in their type, and a
value the types report as possibly missing is guarded or given a
fallback. This prepares for strictNullChecks; the modules behave the
same with the markup they are rendered with.

Values the module's own markup guarantees get a non-null assertion
once strictNullChecks is enabled. Until then
no-unnecessary-type-assertion reports every such assertion, so they
are added together with the option.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
  • Verified V +2 Done
    • Benjamin Kott +2
    • core-ci +1 CI

Issues 2

Files 121

Show 101 more files

Review log 57

  1. Benjamin Kott commented on patch set 1 11/18/26, 12:04

    Cherry Picked from branch main. The following files contain Git conflicts: * Build/Sources/TypeScript/backend/form-engine/field-control/password-generator.ts * Build/Sources/TypeScript/backend/modal.ts * typo3/sysext/viewpage/Resources/Public/JavaScript/main.js
  2. Benjamin Kott uploaded patch set 2 11/18/26, 12:10

  3. core-ci voted on patch set 1 V -1 11/18/26, 12:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114871

  4. core-ci voted on patch set 2 V +1 11/18/26, 12:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114873

  5. Benjamin Kott commented on patch set 2 11/18/26, 17:33

    This change is ready for review.
  6. Benjamin Kott voted on patch set 2 CR +2 V +2 11/18/26, 17:33

  7. Benjamin Kott merged patch set 3 11/18/26, 17:33