#111092Guard nullable values in TypeScript
Description
Across core and several extensions, the JavaScript reads values that can be missing at runtime without a check: elements returned by querySelector(), closest() and getElementById(), and dataset attributes. A missing element then throws a TypeError, and a missing attribute ends up as the string undefined or as NaN. Properties that are initialised with null do not declare it in their type.
These places should get a guard or a fallback where the value can really be missing, and a non-null assertion where the module’s own markup guarantees it. Properties should declare null where it is assigned
Reviews 2
Related issues 1
History 211
-
Gerrit Code Review pushed patch set 3 for main to change 95425 status
NewUnder Review <span data-processor="relativetime" data-value="2026-10-15T21:02:37+00:00" > 10/15/26, 21:02 </span> -
Gerrit Code Review pushed patch set 4 for main to change 95425 <span data-processor="relativetime" data-value="2026-10-16T07:45:42+00:00" > 10/16/26, 07:45 </span>
-
Ayke Halder changed Related to #105423 <span data-processor="relativetime" data-value="2026-10-16T09:10:44+00:00" > 10/16/26, 09:10 </span>
-
Gerrit Code Review pushed patch set 5 for main to change 95425 <span data-processor="relativetime" data-value="2026-10-16T09:26:34+00:00" > 10/16/26, 09:26 </span>
-
Gerrit Code Review pushed patch set 6 for main to change 95425 <span data-processor="relativetime" data-value="2026-10-23T14:49:13+00:00" > 10/23/26, 14:49 </span>
-
Gerrit Code Review pushed patch set 7 for main to change 95425 <span data-processor="relativetime" data-value="2026-10-23T15:42:33+00:00" > 10/23/26, 15:42 </span>
-
Gerrit Code Review pushed patch set 8 for main to change 95425 <span data-processor="relativetime" data-value="2026-11-18T10:59:55+00:00" > 11/18/26, 10:59 </span>
-
Gerrit Code Review pushed patch set 1 for 14.3 to change 97789 <span data-processor="relativetime" data-value="2026-11-18T12:04:45+00:00" > 11/18/26, 12:04 </span>
-
Gerrit Code Review pushed patch set 2 for 14.3 to change 97789 <span data-processor="relativetime" data-value="2026-11-18T12:10:19+00:00" > 11/18/26, 12:10 </span>
-
Gerrit Code Review pushed patch set 9 for main to change 95425 <span data-processor="relativetime" data-value="2026-11-18T14:47:17+00:00" > 11/18/26, 14:47 </span>
-
Benjamin Kott commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2026-11-18T17:35:15+00:00" > 11/18/26, 17:35 </span>
Applied in changeset commit:706db87a1279ee423dc2b7549314265edac4e198.