Review 14.3 Merged

97797[TASK] Guard nullable values in backend modules

Benjamin Kott CR +2 V +2 Hard +145 −121 updated 11/18/26, 18:09

Commit message

In the admin panel and in the modules for backend users, reactions,
recycler, redirects, scheduler and workspaces, a value the types
report as possibly missing is guarded or given a fallback. This
prepares for strictNullChecks; the modules behave the same with the
markup they are rendered with.

Values the module's own markup guarantees get a non-null assertion
once strictNullChecks is enabled, as no-unnecessary-type-assertion
reports every such assertion until then.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
  • Verified V +2 Done
    • Benjamin Kott +2
    • core-ci +1 CI

Issues 2

Files 36

Show 16 more files

Review log 57

  1. Benjamin Kott commented on patch set 1 11/18/26, 17:43

    Cherry Picked from branch main. The following files contain Git conflicts: * Build/Sources/TypeScript/reactions/try-out-modal.ts * Build/Sources/TypeScript/workspaces/preview.ts * typo3/sysext/reactions/Resources/Public/JavaScript/try-out-modal.js * typo3/sysext/recycler/Resources/Public/JavaScript/recycler.js * typo3/sysext/workspaces/Resources/Public/JavaScript/backend.js * typo3/sysext/workspaces/Resources/Public/JavaScript/preview.js
  2. Benjamin Kott uploaded patch set 2 11/18/26, 17:49

  3. Benjamin Kott commented on patch set 2 11/18/26, 17:50

    This change is ready for review.
  4. core-ci voted on patch set 1 V -1 11/18/26, 17:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114895

  5. core-ci voted on patch set 2 V +1 11/18/26, 17:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114896

  6. Benjamin Kott voted on patch set 2 CR +2 V +2 11/18/26, 18:09

  7. Benjamin Kott merged patch set 3 11/18/26, 18:09