Review main Ready for review

97846[BUGFIX] Allow separate label for link and input buttons

Benni Mack CR 0 V -1 Normal +209 −5 updated 11/20/26, 07:23

Commit message

LinkButton and InputButton show their title as visible text when
label text is enabled. A short visible text therefore meant
dropping the descriptive title, which is used as tooltip and as
description for assistive technologies.

Both buttons now provide setLabel() and getLabel() like
GenericButton. The label is shown as visible text and the title is
kept in the title attribute. Without a label, the title is shown
as before. SplitButton respects the label of its primary button and
of input button options as well.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 1
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/46/97846/1 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/46/97846/1 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V -1 Blocked
    • Josua Vogel -1
    • core-ci +1 CI

Merge conflicts 3

Issues 1

Files 7

Review log 23

  1. Benni Mack uploaded patch set 1 11/19/26, 13:58

  2. core-ci voted on patch set 1 V +1 11/19/26, 14:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/115015

  3. Josua Vogel commented on patch set 1 V -1 11/20/26, 07:23

    Unresolved

    is this a feature or a bugfix? 😄 the commit message states bugfix, but you added a feature rst