Review main Ready for review

97849[TASK] Use flat labels in LanguageService

Benni Mack CR 0 V 0 Normal +145 −75 updated 11/19/26, 17:00

Commit message

LanguageService still kept labels in the historical $LOCAL_LANG
structure, keyed by language and with an additional set of "default"
labels loaded for every language file. The fallback chain of a locale
is resolved by LocalizationFactory via Symfony Translator already, so
LanguageService now works on a flat list of labels, which the new
internal LocalizationFactory->getLabels() returns for a Locale.

This removes the protected methods readLLfile() and getLLL() of
LanguageService. The source labels are only loaded where the label set
of a resource is needed, in getLabelsFromResource().

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 2
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/49/97849/2 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/49/97849/2 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 4

Issues 2

Files 3

Review log 35

  1. Benni Mack uploaded patch set 1 11/19/26, 16:51

  2. Benni Mack uploaded patch set 2 11/19/26, 16:54

  3. Benni Mack marked it ready for review 11/19/26, 16:54

  4. core-ci voted on patch set 1 V +1 11/19/26, 16:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/115028

  5. core-ci voted on patch set 2 V +1 11/19/26, 17:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/115029