Issue Task Under Review Stale

#110425Reduce column type comment handling to MySQL

Stefan Bürk 08/11/26, 01:24 updated 09/02/26, 13:16

Description

With SQLite declaring dedicated JSON and UUID column types (sub-task 3), the doctrine type hint comment is only needed for a single type on a single platform family: neither MySQL nor MariaDB – including 11.7, which doctrine does not map to its native UUID type – offer a declaration that tells a GUID apart from any other CHAR(36). PostgreSQL never needed the comment, it has native json, jsonb and uuid types.

Fix

Keep the type comment where it is needed and remove TYPO3\CMS\Core\Database\Platform\PostgreSQLPlatform and PostgreSQL120Platform together with their entries in the driver middleware. Both only carried GetColumnDeclarationSQLCommentTypeAwareTrait and are empty without it, both are annotated internal@, and both were only ever instantiated there.

typeRequiresCommentHint() no longer needs its platform to type map either; the trait is used by the extended MySQL and MariaDB platforms only, so a plain type check is left and the reasoning why no other platform or type qualifies is documented in place.

Existing installations

Introspection keeps resolving an existing type comment on all platforms. Installations created before this still carry them, and the extended schema managers map those columns back to the same doctrine type. This is documented as Important, not as Breaking.

Supersedes the intent of Gerrit 93670.

Patch

Gerrit 95190, topic database-analyzer.

Releases: main

Reviews 1

History 09