Review main Work in progress Stale

95190[WIP][TASK] Reduce column type comment handling to MySQL

Stefan Bürk CR 0 V 0 Normal +50 −105 updated 09/02/26, 13:27

Commit message

With SQLite declaring dedicated `JSON` and `UUID` column types, the
`(DC2Type:<name>)` column comment is only needed for a single type
on a single platform family: neither MySQL nor MariaDB - including
11.7, which doctrine does not map to its native `UUID` type - offer
a declaration that tells a GUID apart from any other `CHAR(36)`.

PostgreSQL never needed the comment, it has native `json`, `jsonb`
and `uuid` types. The extended PostgreSQL platform classes only
carried `GetColumnDeclarationSQLCommentTypeAwareTrait` and are
empty without it, so they are removed together with their entries
in the driver middleware. Both classes are `@internal` and were
only ever instantiated there.

`typeRequiresCommentHint()` no longer needs its platform to type
map either. The trait is used by the extended MySQL and MariaDB
platforms only, so a plain type check is left, and the reasoning
why no other platform or type qualifies is documented in place.

Note that introspection keeps resolving an existing type comment on
all platforms. Installations created before this still carry them,
and the extended schema managers map those columns back to the same
Doctrine type.

This change prepares the ongoing streamlining of the database
analyzer stack, and is useful on its own.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 11
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/90/95190/11 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/90/95190/11 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Relation chain 8

  1. main 95195[WIP][!!!][TASK] Remove SchemaMigrator::install() Based on this change Work in progress Merge conflict Stefan Bürk CR 0 V 0 database-analyzer Normal +62 −37
  2. main 95194[WIP][!!!][TASK] Remove the array shaped schema migrator API Based on this change Work in progress Merge conflict Stefan Bürk CR 0 V 0 database-analyzer Nightmare +1441 −3637
  3. main 95193[WIP][FEATURE] Add database schema update command Based on this change Work in progress Stefan Bürk CR 0 V 0 database-analyzer Expert +1066 −0
  4. main 95192[WIP][TASK] Rework database analyzer stack Based on this change Work in progress Merge conflict Stefan Bürk CR 0 V 0 database-analyzer Nightmare +5239 −372
  5. main 95191[WIP][TASK] Generate table option changes without platform hooks Based on this change Work in progress Stefan Bürk CR 0 V 0 database-analyzer Hard +92 −282
  6. 95190 [WIP][TASK] Reduce column type comment handling to MySQL This change

  7. main 95189[WIP][TASK] Use non-deprecated doctrine introspection API This change is based on it Work in progress Stefan Bürk CR 0 V 0 → 14.3, 13.4 database-analyzer Expert +450 −599
  8. main 95263[TASK] Raise doctrine/dbal to ~4.4.4 This change is based on it Merged Stefan Bürk CR +2 V +2 → 14.3, 13.4 database-analyzer Normal +57 −5

Merge conflicts 2

Issues 2

Files 7

Review log 1122

  1. Stefan Bürk uploaded patch set 1 08/09/26, 21:00

  2. core-ci voted on patch set 1 V +1 08/09/26, 21:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106230

  3. Stefan Bürk rebased onto patch set 2 V +1 08/11/26, 00:32

  4. core-ci voted on patch set 2 V +1 08/11/26, 00:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106354

  5. Stefan Bürk uploaded patch set 3 V +1 08/11/26, 04:00

  6. core-ci voted on patch set 3 V +1 08/11/26, 04:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106369

  7. Stefan Bürk rebased onto patch set 4 V +1 08/11/26, 05:17

  8. core-ci voted on patch set 4 V +1 08/11/26, 05:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106388

  9. Stefan Bürk rebased onto patch set 5 V +1 08/11/26, 11:38

  10. core-ci voted on patch set 5 V +1 08/11/26, 11:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106419

  11. Stefan Bürk rebased onto patch set 6 V +1 08/11/26, 13:29

  12. core-ci voted on patch set 6 V +1 08/11/26, 13:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106435

  13. Stefan Bürk uploaded patch set 7 08/11/26, 14:14

    Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  14. core-ci voted on patch set 7 V +1 08/11/26, 14:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106449

  15. Stefan Bürk rebased onto patch set 8 V +1 08/14/26, 20:48

  16. core-ci voted on patch set 8 V +1 08/14/26, 21:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106725

  17. Stefan Bürk rebased onto patch set 9 V +1 08/31/26, 10:28

  18. core-ci voted on patch set 9 V +1 08/31/26, 10:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107409

  19. Stefan Bürk rebased onto patch set 10 V +1 09/02/26, 10:40

  20. core-ci voted on patch set 10 V +1 09/02/26, 10:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107594

  21. Stefan Bürk rebased onto patch set 11 V +1 09/02/26, 13:16

  22. core-ci voted on patch set 11 V +1 09/02/26, 13:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107629