#110739Inline (IRRE) records in a flexform can't be expanded/collapsed when field name contains a `.`
Description
[PLACEHOLDER TO GET AN ISSUE NUMBER – WILL BE UPDATED TODAY]
Reviews 2
Related issues 1
History 711
-
Gerrit Code Review pushed patch set 1 for main to change 95913 status
NewUnder Review <span data-processor="relativetime" data-value="2026-09-18T11:59:04+00:00" > 09/18/26, 11:59 </span> -
Krystian Liński commented <span data-processor="relativetime" data-value="2026-09-18T12:24:45+00:00" > 09/18/26, 12:24 </span>
One addition: FileReferenceContainer needs the same change. It builds the toggle the same way, around line 278, and both files got this markup in the same commit (075df31c6b).
The panels also nest, so fixing only InlineRecordContainer is not enough: an inline record inside a FlexForm opens, but the file panels inside it stay closed, so you still cannot edit its images.
Rather than duplicating the escaping in two containers, it could live in one place. Both extend AbstractContainer, and any future container with a collapse toggle would get it for free:
--- a/Classes/Form/Container/AbstractContainer.php + protected static function escapeSelector(string $identifier): string + { + return preg_replace('/[^A-Za-z0-9_-]/', '\\\\$0', $identifier) ?? $identifier; + }// InlineRecordContainer and FileReferenceContainer - data-bs-target="#' . $ariaControls . '" + data-bs-target="#' . self::escapeSelector($ariaControls) . '"Only data-bs-target may be escaped: the panel id and aria-controls take an identifier rather than a selector, so they keep the raw value.
Tested on 14.3.7. Both panels open again, and a normal inline record outside a FlexForm is unaffected, since the regex does nothing when the id has no dot.
-
Mike Street commented <span data-processor="relativetime" data-value="2026-09-18T12:28:00+00:00" > 09/18/26, 12:28 </span>
Thanks
I created a patch and, upon doing so, Gerrit informed me it conflicts with this one which seems to remove the dot
https://review.typo3.org/c/Packages/TYPO3.CMS/+/94596
It also updates
FileReferenceContaineras you mentioned.Happy to leave mine in favour of that one.
-
Gerrit Code Review pushed patch set 2 for main to change 95913 <span data-processor="relativetime" data-value="2026-09-18T12:48:30+00:00" > 09/18/26, 12:48 </span>
-
Gerrit Code Review pushed patch set 3 for main to change 95913 <span data-processor="relativetime" data-value="2026-09-18T12:49:14+00:00" > 09/18/26, 12:49 </span>
-
Gerrit Code Review pushed patch set 4 for main to change 95913 <span data-processor="relativetime" data-value="2026-09-18T13:15:20+00:00" > 09/18/26, 13:15 </span>
-
Garvin Hicking changed Related to #110071 <span data-processor="relativetime" data-value="2026-09-21T08:45:37+00:00" > 09/21/26, 08:45 </span>
-
Mike Street commented <span data-processor="relativetime" data-value="2026-09-21T08:58:03+00:00" > 09/21/26, 08:58 </span>
Update: I have implemented Krystian’s suggestions in the patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/95913
-
Oliver Bartsch changed Duplicated by #110931 <span data-processor="relativetime" data-value="2026-10-19T20:46:06+00:00" > 10/19/26, 20:46 </span>
-
Georg Ringer commented and changed status
Under ReviewClosed <span data-processor="relativetime" data-value="2026-11-10T18:31:05+00:00" > 11/10/26, 18:31 </span>has been solved with #110071, therefore closing issue.
if this is still valid for you in latest v14, please create a new issue!
If you have a Flexform with inline records, the collapse/expand functionality doesn’t work for fields with a
.inside them (e.g.settings.pages).This is because bootstap uses
data-bs-targetas a CSS selector pointing to an ID, so if it contains a dot it is assume it is 2 CSS classes concatenated.This can be resolved by escaping the
data-bs-targetinClasses/Form/Container/InlineRecordContainer.phparound line 316 when it is building the container.This is an issue in both TYPO3 13 & 14.
(Apologies for the placeholder Description above – I assume I would be able to update it afterwards)
—-
AI suggested a new function in that class to escape with regex (but could be in place)
And then updating the HTML being built