Issue Bug Under Review

#90841DataHandler-Bugfix: When "sorting"-field of DB-record will be updated, then the "tstamp"-field of that DB-record should also be updated

Jürgen Kußmann 03/26/20, 13:36 updated 11/13/26, 08:34

Description

When the “sorting”-field of a DB-record (e.g. tt_content-record) will be updated, than also the ‘tstamp’-field of that related DB-record should be updated. In our TYPO3-installation, we use the “tstamp”-field of DB-records to check, if the DB-record has changed. So, for us, it’s very, very important, that the “tstamp”-field will always be updated, when the DB-record will change. So, this litle bugfix is crucial for us.

The bugfix is a no-brainer and easy to implement/adopt. The bugfix works fine in TYPO3 8. The same bug also exists in TYPO3 v9 and v10, so you have to fix the bug also for that versions.

Best regards,
Jürgen Kußmann
Software Developer
AOE GmbH

Reviews 3

Files 1

History 913

  1. Benni Mack commented <span data-processor="relativetime" data-value="2020-03-26T14:16:04+00:00" > 03/26/20, 14:16 </span>

    Hey Jürgen,

    thanks for your report. I guess we would need to check if the history (sys_history) is added there as well (this is usually an info that the record was modified).

  2. Oliver Hader commented <span data-processor="relativetime" data-value="2020-03-26T17:14:16+00:00" > 03/26/20, 17:14 </span>

    Hi Jürgen, nice to read from you here again :)

    From an EventSourcing point of view (we don’t have EventSourcing in the core) I totally get to point to check what has changed and only process/project those changes – e.g. trigger rendering of pages that were changed or warm-up their caches again.

    Usually the meaning of “tstamp” was “modified by editor” which actually would not be the case when the sorting value was updated because some other record was inserted and sorting values had to be reprocessed.

    I need to think a little bit about potential implications…

  3. Jürgen Kußmann commented <span data-processor="relativetime" data-value="2020-03-27T07:59:23+00:00" > 03/27/20, 07:59 </span>

    Hi Oli,
    there are several code examples inside the DataHandler-class, where the tstamp (of a none editor changed DB-record) is updated. The “position” where i added the logic to update the tstamp was only the last one, which didn’t contain such a logic. Man könnte also sagen, dass durch meinen Fix die Logik (zum updaten des tstamps) in der DataHandler-Klasse nun überall vorhanden ist – und nicht nur lückenhaft ;-)

    Oliver Hader wrote:
    > Hi Jürgen, nice to read from you here again :)
    >
    > From an EventSourcing point of view (we don’t have EventSourcing in the core) I totally get to point to check what has changed and only process/project those changes – e.g. trigger rendering of pages that were changed or warm-up their caches again.
    >
    > Usually the meaning of “tstamp” was “modified by editor” which actually would not be the case when the sorting value was updated because some other record was inserted and sorting values had to be reprocessed.
    >
    > I need to think a little bit about potential implications…

  4. Oliver Hader commented <span data-processor="relativetime" data-value="2020-03-27T13:30:33+00:00" > 03/27/20, 13:30 </span>

    Alright then… I did not check in detail when tstamp is updated and when not… if it’s updated in other places as well, I’m fine with completing the missing spots

  5. Gerrit Code Review pushed patch set 1 for master to change 63961 status New Under Review <span data-processor="relativetime" data-value="2020-03-28T09:21:10+00:00" > 03/28/20, 09:21 </span>

  6. Oliver Hader commented <span data-processor="relativetime" data-value="2020-03-28T09:27:54+00:00" > 03/28/20, 09:27 </span>

  7. Jürgen Kußmann commented <span data-processor="relativetime" data-value="2020-03-30T09:20:24+00:00" > 03/30/20, 09:20 </span>

    Hi Oli,
    i can’t login at https://review.typo3.org. But nevertheless, the code looks good for me at https://review.typo3.org.

    Best regards,
    Jürgen

    Oliver Hader wrote:
    > * Jürgen, your changes have been pushed to to Gerrit at https://review.typo3.org/q/Ic7244cd3a829eca60c608de5caa09de95f98cf42 – could you please have a look?
    > * Benni, could you please check (or describe) the aspects you described above on sys_history?

  8. Oliver Hader changed status Under Review New target version Complexity no-brainer <span data-processor="relativetime" data-value="2020-05-31T09:55:13+00:00" > 05/31/20, 09:55 </span>