92429[BUGFIX] Keep tstamp of records whose sorting is only renumbered
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 8
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/29/92429/8 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/29/92429/8 && git cherry-pick FETCH_HEAD
Review
-
Code review CR -2 Blocked
- Benni Mack -2
-
Verified V -1 Blocked
- core-ci -1 CI
Merge conflicts 6
- main 93752[BUGFIX] Skip translations when pasting into another language
- main 96543[WIP][POC][TASK] Write and read records by the same rules and rights
- main 96829[!!!][BUGFIX] Restore deleted records by their deletion operation
- main 89309[BUGFIX] DataHandler commands move/copy: Always apply field updates
- main 92859[WIP][BUGFIX] Make MM tables language-aware and workspace-aware
- main 75020[FEATURE] Allow excluding tables from page copy
Issues 2
Files 10
- typo3/sysext/core/Classes/Database/RelationHandler.php+48 −25
- typo3/sysext/core/Documentation/Changelog/14.3.x/Important-91980-ChangedSortingValuesKeepTheTimestampOfARecord.rstnew+40 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/MoveRecord.csv+6 −3
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/MoveActionTest.php+19 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/Modify/DataSet/modifyParentNChangeHotelChildrenSorting.csv+5 −5
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/Modify/DataSet/modifyParentWithUnchangedChildren.csvnew+48 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/Modify/ActionTest.php+16 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/WorkspacesModify/DataSet/modifyParentWithUnchangedChildren.csvnew+80 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/WorkspacesModify/ActionTest.php+19 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/AbstractActionTestCase.php1+13 −0
Review log 1825
-
Benni Mack uploaded patch set 1 01/20/26, 16:17
-
core-ci voted on patch set 1 V +1 01/20/26, 16:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93877
-
Benni Mack rebased onto patch set 2
V +104/21/26, 14:48 -
core-ci voted on patch set 2 V +1 04/21/26, 15:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100655
-
Benni Mack updated the commit message in patch set 3
V +104/22/26, 07:21 -
Benni Mack rebased onto patch set 4 09/01/26, 16:31
-
core-ci voted on patch set 4 V -1 09/01/26, 16:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107503
-
Georg Ringer uploaded patch set 5
V -109/09/26, 15:36 -
core-ci voted on patch set 5 V +1 09/09/26, 15:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108203
-
Simon Schaufelberger voted on patch set 5 CR +1 V +1 10/12/26, 14:21
-
Oliver Klee voted on patch set 5 V +1 10/12/26, 14:47
-
Wouter Wolters voted on patch set 5 CR +1 V +1 10/12/26, 17:36
-
Markus Klein commented on patch set 5 10/12/26, 22:01
Hm... so we had n update statements for the DB Now we have n select statements + m update statements Is that really an improvement? -
Benni Mack commented on patch set 5 10/13/26, 06:13
Reply
writes are more expensive than reads. but in general the main point about this change was really about the last modified date. -
Georg Ringer rebased onto patch set 6
CR +1V +110/13/26, 06:13 -
core-ci voted on patch set 6 V +1 10/13/26, 06:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110973
-
Markus Klein commented on patch set 6 CR +1 10/13/26, 09:05
Reply
So I guess we have no other option than to read the full row to find the correct diff. okay. -
Markus Klein commented on patch set 6 CR 0 V +1 10/13/26, 09:06
AbstractActionTestCase.php:568This actually verifies nothing. The actual test does. -
Benni Mack wrote 10/15/26, 22:32
Topic set to DataHandler -
Georg Ringer rebased onto patch set 7
V +110/25/26, 11:42 -
Benni Mack commented on patch set 7 CR -2 10/25/26, 11:42
will recheck this again -
Benni Mack marked it work in progress 10/25/26, 11:42
-
core-ci voted on patch set 7 V +1 10/25/26, 11:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112483
-
Benni Mack uploaded patch set 8
V +111/13/26, 08:34Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 8 V -1 11/13/26, 08:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114288