Review main Work in progress

92429[BUGFIX] Keep tstamp of records whose sorting is only renumbered

Benni Mack CR -2 V -1 Hard +294 −33 updated 11/13/26, 08:45

Commit message

When saving a parent record with IRRE children, all children were
written and got a new tstamp, even if none of their values changed.

RelationHandler->writeForeignField() now only writes the values of a
child which differ from the database, and only updates the tstamp if
the pointer to the parent, the parent table or a match field changed.
Renumbering the sorting value of a child is no modification of the
child itself, in the same way DataHandler does not update the tstamp
of records whose sorting is shifted to make room for a moved record.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 8
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/29/92429/8 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/29/92429/8 && git cherry-pick FETCH_HEAD

Review

  • Code review CR -2 Blocked
    • Benni Mack -2
  • Verified V -1 Blocked
    • core-ci -1 CI

Merge conflicts 6

Issues 2

Files 10

Review log 1825

  1. Benni Mack uploaded patch set 1 01/20/26, 16:17

  2. core-ci voted on patch set 1 V +1 01/20/26, 16:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93877

  3. Benni Mack rebased onto patch set 2 V +1 04/21/26, 14:48

  4. core-ci voted on patch set 2 V +1 04/21/26, 15:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100655

  5. Benni Mack updated the commit message in patch set 3 V +1 04/22/26, 07:21

  6. Benni Mack rebased onto patch set 4 09/01/26, 16:31

  7. core-ci voted on patch set 4 V -1 09/01/26, 16:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107503

  8. Georg Ringer uploaded patch set 5 V -1 09/09/26, 15:36

  9. core-ci voted on patch set 5 V +1 09/09/26, 15:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108203

  10. Simon Schaufelberger voted on patch set 5 CR +1 V +1 10/12/26, 14:21

  11. Oliver Klee voted on patch set 5 V +1 10/12/26, 14:47

  12. Wouter Wolters voted on patch set 5 CR +1 V +1 10/12/26, 17:36

  13. Markus Klein commented on patch set 5 10/12/26, 22:01

    Hm... so we had n update statements for the DB Now we have n select statements + m update statements Is that really an improvement?
  14. Benni Mack commented on patch set 5 10/13/26, 06:13

    Reply

    writes are more expensive than reads. but in general the main point about this change was really about the last modified date.
  15. Georg Ringer rebased onto patch set 6 CR +1 V +1 10/13/26, 06:13

  16. core-ci voted on patch set 6 V +1 10/13/26, 06:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110973

  17. Markus Klein commented on patch set 6 CR +1 10/13/26, 09:05

    Reply

    So I guess we have no other option than to read the full row to find the correct diff. okay.
  18. Markus Klein commented on patch set 6 CR 0 V +1 10/13/26, 09:06

    AbstractActionTestCase.php:568

    This actually verifies nothing. The actual test does.
  19. Benni Mack wrote 10/15/26, 22:32

    Topic set to DataHandler
  20. Georg Ringer rebased onto patch set 7 V +1 10/25/26, 11:42

  21. Benni Mack commented on patch set 7 CR -2 10/25/26, 11:42

    will recheck this again
  22. Benni Mack marked it work in progress 10/25/26, 11:42

  23. core-ci voted on patch set 7 V +1 10/25/26, 11:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112483

  24. Benni Mack uploaded patch set 8 V +1 11/13/26, 08:34

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  25. core-ci voted on patch set 8 V -1 11/13/26, 08:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114288