Review main Ready for review Orphaned

66903[BUGFIX] Respect all languages for sorting in `DataHandler`

Markus Gerdes CR 0 V -1 Easy +11 −0 updated 04/22/26, 13:08

Commit message

This change adds an extra query part to fetch
`sys_languague_uid = -1 ` for the sorting in a
page, during resorting the fetched "all language"
records are respected.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 15
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/03/66903/15 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/03/66903/15 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V -1 Blocked
    • core-ci -1 CI

Merge conflicts 13

Issues 1

Files 1

Review log 2036

Show 611 earlier messages
  1. Markus Gerdes uploaded patch set 1 11/25/20, 17:41

  2. TYPO3com voted on patch set 1 V +1 11/25/20, 17:53 Completed build in 11m 31s on Wed, 25 Nov, 05:53 PM Test Summary: 32394 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7579

  3. Benni Mack uploaded patch set 2 04/29/21, 19:45

  4. core-ci voted on patch set 2 V -1 04/29/21, 19:56 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10937

  5. Anja Leichsenring rebased onto patch set 3 05/04/21, 18:29

  6. core-ci voted on patch set 3 V -1 05/04/21, 18:41 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11147

  7. Benni Mack updated the commit message in patch set 4 11/18/21, 10:37

  8. core-ci voted on patch set 4 V -1 11/18/21, 11:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19449

  9. Benni Mack wrote 11/29/21, 10:16

    Change destination moved from master to main
  10. Benni Mack updated the commit message in patch set 5 11/29/21, 14:02

  11. core-ci voted on patch set 5 V -1 11/29/21, 18:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20074

  1. Benni Mack updated the commit message in patch set 6 V -1 05/03/23, 09:14

  2. core-ci voted on patch set 6 V -1 05/03/23, 09:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41384

  3. Oliver Hader rebased onto patch set 7 V -1 05/03/23, 11:54

  4. core-ci voted on patch set 7 V -1 05/03/23, 12:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41523

  5. Stefan Bürk uploaded patch set 8 V -1 05/15/23, 19:30

  6. Stefan Bürk updated the commit message in patch set 9 05/15/23, 19:41

  7. core-ci voted on patch set 8 V +1 05/15/23, 19:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41850

  8. core-ci voted on patch set 9 V +1 05/15/23, 19:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41852

  9. Markus Gerdes voted on patch set 9 CR +1 V +1 11/22/23, 16:31

  10. Stefan Bürk commented on patch set 9 01/06/24, 22:38

    DataHandler.php:4750

    We do not use pdo directly anymore, should be Connetion::PARAM_INT instead.
  11. Markus Gerdes commented on patch set 10 CR +1 V +1 01/08/24, 16:21

    Published edit on patch set 9.
  12. JAKOTA Design Group GmbH commented on patch set 10 01/08/24, 16:38

    DataHandler.php:4751

    Shouldn't this take advantage of the $languageField var? $queryBuilder->expr()->eq($languageField, -1)
  13. core-ci voted on patch set 10 V -1 01/08/24, 20:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51270

  14. core-ci commented on patch set 10 01/08/24, 22:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51270

  15. Markus Gerdes rebased onto patch set 11 V -1 01/09/24, 02:59

  16. core-ci voted on patch set 11 V +1 01/09/24, 03:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51294

  17. Markus Gerdes commented on patch set 12 V +1 02/12/24, 16:06

    Published edit on patch set 11.
  18. Markus Gerdes commented on patch set 12 02/12/24, 16:08

    DataHandler.php:4750 Reply

    Done

    DataHandler.php:4751 Reply

    Done
  19. core-ci voted on patch set 12 V +1 02/12/24, 16:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53097

  20. Benni Mack updated the commit message in patch set 13 V +1 10/18/24, 13:21

  21. core-ci voted on patch set 13 V -1 10/18/24, 13:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67956

  22. Benni Mack uploaded patch set 14 V -1 03/28/25, 12:25

  23. core-ci voted on patch set 14 V +1 03/28/25, 12:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76584

  24. Benni Mack updated the commit message in patch set 15 V +1 04/22/26, 06:55

  25. core-ci voted on patch set 15 V -1 04/22/26, 11:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100831