84879[FEATURE] Allow record fields permissions preview
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 18
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/79/84879/18 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/79/84879/18 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V -1 Blocked
- core-ci -1 CI
Merge conflicts 19
- main 97304[WIP][BUGFIX] Render the record form from unsaved values
- main 94552[WIP][FEATURE] Passwordless passkey login for the backend
- main 84995[FEATURE] Allow assigning users to groups in group editor
- main 93599[WIP][TASK] Migrate resource endpoints to Actions API
- main 97327[WIP][TASK] Migrate file storage tree to Actions API
- main 92191[WIP][TASK] Migrate PageTree to Action API
- main 91304[TASK] Move all LGL labels in core extension to dedicated file and unify syntax
- main 94753[FEATURE] New TCA type "coordinate"
- main 96543[WIP][POC][TASK] Write and read records by the same rules and rights
- main 87873[WIP][BUGFIX] Make Dropdown Toggle Buttons more accessible
- main 92257[WIP] Toolbar
- main 94507[FEATURE] Add cross-system clipboard for tt_content records
- main 91423[WIP][TASK] Move config values to both section columns and config
- main 92851[WIP][FEATURE] Allow simplified TCA configuration (Test II)
- main 91189[WIP] Module Menu
- main 92177[!!!][FEATURE] Autoconfigure backend FormEngine node types
- main 92180[!!!][TASK] Decouple registration of FormEngine nodes from NodeFactory
- main 90644[POC][FEATURE] Introduce attribute-based backend module registration
- main 83208[WIP][FEATURE] Introduce Creation Wizards
Issues 1
Files 14
- Build/Sources/TypeScript/backend/form-engine/element/exclude-fields-element.tsnew+73 −0
- Build/Sources/TypeScript/backend/record-form-preview.tsnew+36 −0
- typo3/sysext/backend/Classes/Controller/RecordFormPreviewController.phpnew+346 −0
- typo3/sysext/backend/Classes/Form/Element/SelectCheckBoxElement.php+21 −1
- typo3/sysext/backend/Classes/Form/Element/SelectCheckBoxExcludeFieldsElement.phpnew+88 −0
- typo3/sysext/backend/Classes/Form/NodeFactory.php+1 −0
- typo3/sysext/backend/Configuration/Backend/AjaxRoutes.php+7 −0
- typo3/sysext/backend/Configuration/Backend/Routes.php+6 −0
- typo3/sysext/backend/Resources/Private/Language/locallang_form_preview.xlfnew+58 −0
- typo3/sysext/backend/Resources/Private/Templates/Form/RecordFormPreview.htmlnew+108 −0
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/exclude-fields-element.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/record-form-preview.jsnew+13 −0
- typo3/sysext/core/Configuration/TCA/be_groups.php+1 −1
- typo3/sysext/core/Documentation/Changelog/15.0/Feature-104034-AllowToPreviewFormsBasedOnBackendGroupPermissions.rstnew+57 −0
Review log 2747
Show 1222 earlier messages
-
Marcin Sągol uploaded patch set 1 06/24/24, 09:49
-
core-ci voted on patch set 1 V -1 06/24/24, 09:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60165
-
Marcin Sągol uploaded patch set 2
V -106/24/24, 10:28 -
core-ci voted on patch set 2 V -1 06/24/24, 10:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60168
-
Christian Kuhn commented on patch set 2 06/24/24, 10:45
i wonder if we *really* need the preview interface and couldn't handle something like that without. i had a better access list selection in mind when i designed formEngine rewrite back then in v7 / v8, and i think it would make sense to give me a chance having a look. has this additional interface been aligned with some other coreteam member, yet? -
Marcin Sągol commented on patch set 2 06/24/24, 12:14
Reply Unresolved
Now I have doubts if it should be introduced. Maybe the NodeInterface could be just extended to include this new renderPreview method. Now we have some incomaptibility: `Call to an undefined method TYPO3\CMS\Backend\Form\NodeInterface::renderPreview().` as i am calling the metod in `SingleFieldContainer` and the returned type from the `create()` method is NodeInterface: ``` if ((($options['context'] ?? 'live') === 'preview')) { return $this->nodeFactory->create($options)->renderPreview(); } ``` I have discussed the changes in abstract method with @bo@cedev.de, i am no 100% sure if he also agreed on the new interface back then. -
Marcin Sągol rebased onto patch set 3
V -106/26/24, 13:32 -
core-ci voted on patch set 3 V -1 06/26/24, 13:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60390
-
Marcin Sągol uploaded patch set 4
V -106/26/24, 13:55 -
core-ci voted on patch set 4 V -1 06/26/24, 14:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60391
-
Marcin Sągol uploaded patch set 5
V -106/26/24, 22:03 -
core-ci voted on patch set 5 V -1 06/26/24, 22:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60419
-
Marcin Sągol uploaded patch set 6
V -106/26/24, 22:27 -
core-ci voted on patch set 6 V -1 06/26/24, 22:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60420
-
Marcin Sągol uploaded patch set 7
V -106/26/24, 22:51 -
core-ci voted on patch set 7 V -1 06/26/24, 22:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60421
-
Marcin Sągol uploaded patch set 8
V -106/27/24, 09:35 -
core-ci voted on patch set 8 V -1 06/27/24, 09:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60443
-
Marcin Sągol uploaded patch set 9
V -106/27/24, 10:20 -
Marcin Sągol uploaded patch set 10 06/27/24, 10:23
-
core-ci voted on patch set 9 V -1 06/27/24, 10:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60446
-
core-ci voted on patch set 10 V -1 06/27/24, 10:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60447
-
core-ci commented on patch set 10 06/27/24, 10:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60447
-
core-ci commented on patch set 10 06/27/24, 10:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60447
-
Marcin Sągol rebased onto patch set 11
V -106/27/24, 20:27 -
core-ci voted on patch set 11 V +1 06/27/24, 20:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60495
-
Marcin Sągol rebased onto patch set 12
V +106/28/24, 10:14 -
core-ci voted on patch set 12 V +1 06/28/24, 10:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60546
-
Marcin Sągol uploaded patch set 13
V +106/30/24, 10:48 -
core-ci voted on patch set 13 V +1 06/30/24, 10:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60662
-
Oskar Dydo uploaded patch set 14
V +109/05/24, 11:18 -
core-ci voted on patch set 14 V -1 09/05/24, 11:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64856
-
Oskar Dydo uploaded patch set 15
V -109/05/24, 11:38 -
core-ci voted on patch set 15 V +1 09/05/24, 11:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64861
-
Guido Schmechel commented on patch set 15 V +1 09/07/24, 16:50
Tested with a TYPO3 standard installation -
Oskar Dydo uploaded patch set 16
V +109/13/24, 09:45 -
core-ci voted on patch set 16 V -1 09/13/24, 09:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65650
-
Oskar Dydo uploaded patch set 17 09/13/24, 10:14
Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**") -
core-ci voted on patch set 17 V +1 09/13/24, 10:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65656
-
Guido Schmechel voted on patch set 17 V +1 09/13/24, 14:50
-
Markus Klein commented on patch set 17 09/13/24, 17:30
Isn't this a breaking change with the Interface modification? I still find that acceptable, but it should still be marked as such. -
Stefan Bürk commented on patch set 17 09/14/24, 23:46
Reply
Adding interface method is breaking, and implementing custom node implementation is a thing which is done in agencies. Marking as breaking is not enough and cannot be done outside of .0 release. Not looked into this change at all, but it could not been made non-breaking (elements not having the renderPreview method implemented) it cannot be done in v13 - and not seconds before freeze release. Using a dedicated interface only defining the `renderPreview` method may be a way, and the abstract could implement that method (if it is suitable for ALL implementations extending the abstract without breaking).Calling code should check for the interface. A fallback strategy needs to be planned - rendering a `preview for xx not possible` instead of silently not showing it ? -
Benni Mack commented on patch set 17 04/09/25, 18:15
Reply Unresolved
just FYI. As this is/was breaking - now is the time to make this patch ready and mark it as breaking -
Benni Mack commented on patch set 17 07/24/25, 15:40
There is no activity in the past 10 months, will set this to WIP now -
Benni Mack marked it work in progress 07/24/25, 15:40
-
Marcin Sągol uploaded patch set 18
V +108/06/26, 22:27 -
core-ci voted on patch set 18 V -1 08/06/26, 22:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106081