84998[BUGFIX] Properly evaluate preview requirements for rootline
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 9
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/98/84998/9 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/98/84998/9 && git cherry-pick FETCH_HEAD
Review
-
Code review CR -2 Blocked
- Oli Bartsch -2
-
Verified V -1 Blocked
- core-ci -1 CI
Relation chain 2
-
84998 [BUGFIX] Properly evaluate preview requirements for rootline This change
- main 97265[BUGFIX] Skip group simulation for group members
Merge conflicts 1
Issues 2
Files 4
- typo3/sysext/frontend/Classes/Middleware/PreviewSimulator.php2+11 −17
- typo3/sysext/frontend/Tests/Functional/Middleware/Fixtures/previewSimulatorCases.csv+8 −4
- typo3/sysext/frontend/Tests/Functional/Middleware/Fixtures/previewSimulatorRootlineCases.csvnew+12 −0
- typo3/sysext/frontend/Tests/Functional/Middleware/PreviewSimulatorTest.php+96 −1
Review log 1423
-
Oli Bartsch uploaded patch set 1 06/28/24, 15:26
-
core-ci voted on patch set 1 V +1 06/28/24, 15:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60573
-
Benni Mack uploaded patch set 2
V +107/02/24, 17:53 -
core-ci voted on patch set 2 V +1 07/02/24, 17:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/60857
-
Fabien Udriot voted on patch set 2 CR +1 07/10/24, 11:01
-
Oli Bartsch commented on patch set 2 CR -2 07/10/24, 12:39
Working on tests. -
Benni Mack updated the commit message in patch set 3
CR +1V +110/18/24, 13:37Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 3 V -1 10/18/24, 22:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68007
-
Benni Mack marked it work in progress 03/22/25, 12:33
-
Benni Mack uploaded patch set 4
V -104/11/25, 12:08Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 4 V +1 04/11/25, 12:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77526
-
Benni Mack commented on patch set 4 05/16/25, 08:58
PreviewSimulator.php:120should this "break" also be removed? -
Oli Bartsch rebased onto patch set 5
V +105/19/25, 08:31Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 5 V +1 05/19/25, 08:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79140
-
Oli Bartsch uploaded patch set 6
V +111/06/26, 08:54Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 6 V -1 11/06/26, 09:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113470
-
Oli Bartsch rebased onto patch set 7
V -111/06/26, 09:52Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 7 V +1 11/06/26, 10:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113479
-
Benni Mack uploaded patch set 8
V +111/19/26, 09:23Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Benni Mack commented on patch set 8 11/19/26, 09:29
This change is ready for review.Hi Oli, I pushed patch set 8 on top of #97265, since both touch PreviewSimulator and add the same test class. In addition I did this: - simulateDate() / simulateUserGroup() now run before the page and rootline checks. If the simulated group or time grants access to the rootline, includeHiddenPages stays off, so hidden pages no longer show up in menus during simulation. The current page is evaluated at the simulated time as well. Two tests cover this (they fail without the reorder). Your -2 from 2024 ("Working on tests") was copied again. Tests are there now, so could you remove it if you're fine with the changes? Would be cool if you read through my changes compared to your version.PreviewSimulator.php:120ReplyDone -
core-ci voted on patch set 8 V -1 11/19/26, 09:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114983
-
Benni Mack rebased onto patch set 9
V -111/19/26, 09:37Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 9 V -1 11/19/26, 09:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114987