97235[BUGFIX] Preview hidden pages across site domains
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 12
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/35/97235/12 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/35/97235/12 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Relation chain 3
- main 96718[WIP] Add device preview with zoom and pan to the preview module
- main 97236[FEATURE] Compare every preview with the live page
-
97235 [BUGFIX] Preview hidden pages across site domains This change
Merge conflicts 60
- main 97304[WIP][BUGFIX] Render the record form from unsaved values
- main 97535[!!!][FEATURE] Introduce site language option "languageMode"
- main 94552[WIP][FEATURE] Passwordless passkey login for the backend
- main 84998[BUGFIX] Properly evaluate preview requirements for rootline
- main 95436[WIP][TASK] Initialise class properties across the JavaScript stack
- main 95435[WIP][TASK] Enable strictNullChecks for the TypeScript build
- main 97760[TASK] Send Cross-Origin-Opener-Policy in backend
- main 97700[BUGFIX] Allow workspace preview frames on other site hosts
- main 97437[BUGFIX] Serve admin panel actions from the frontend origin
- main 97436[!!!][FEATURE] Link content elements as records
- main 97646[BUGFIX] Hide reload button in FormEngine forms
- main 97607[BUGFIX] Apply additional parameters of redirect targets
- main 90502[!!!][TASK] Refactor link-viewhelpers and fix inconsistencies
- main 95741[BUGFIX] Offer localization only where it is permitted
- main 84995[FEATURE] Allow assigning users to groups in group editor
- main 97236[FEATURE] Compare every preview with the live page
- main 96718[WIP] Add device preview with zoom and pan to the preview module
- main 93599[WIP][TASK] Migrate resource endpoints to Actions API
- main 97327[WIP][TASK] Migrate file storage tree to Actions API
- main 92191[WIP][TASK] Migrate PageTree to Action API
- main 97165[FEATURE] Offer file and folder search options
- main 97164[BUGFIX] Ask for required fields when translating a page
- main 95105[TASK] Apply PHP code simplifications
- main 91093[BUGFIX] Add accessible relation between dropdown and its toggle
- main 96543[WIP][POC][TASK] Write and read records by the same rules and rights
- main 97026[TASK] Reuse parent rootlines for page links
- main 90667[BUGFIX] Skip invalid parameters while creating editing form
- main 96319[FEATURE] Undo operations from their notification
- main 87873[WIP][BUGFIX] Make Dropdown Toggle Buttons more accessible
- main 92257[WIP] Toolbar
- main 62956[WIP][TASK] Improves redirect performance with large redirects table
- main 96159[TASK] Use short translation domain syntax in EXT:workspaces
- main 88948[!!!][TASK] Refactor Property Handling in AbstractDomainObject
- main 95145[TASK] Migrate LanguageService->sL() labels to new domain syntax
- main 95278[FEATURE] Add event to render content around record edit form
- main 91430[TASK] Replace "OK" label in modal and use the new syntax for "Discard"
- main 95453[WIP][TASK] Use ajax to load the delete message
- main 95308[TASK] Deprecate QueryBuilder::castFieldToTextType()
- main 94653[WIP] Record Identity
- main 94207[FEATURE] Explicit access declaration for backend routes
- main 92471[POC] Page Layout Views
- main 91189[WIP] Module Menu
- main 70840[WIP][FEATURE] Add possibility to add HTTP headers in frontend
- main 81049[WIP][FEATURE] Allow missing local storage files to be handled by TYPO3
- main 92943[WIP][TASK] Deprecate inline language labels (TYPO3.lang)
- main 92959[WIP][TASK] Use ICU message format for pluralization
- main 90042[WIP][TASK] streamline workspace preview hydration
- main 83623[WIP][FEATURE] Introduce System Settings API & Editor
- main 90644[POC][FEATURE] Introduce attribute-based backend module registration
- main 83594[TASK] Move EXT:frontend default TypoScript to Configuration folder
- main 83208[WIP][FEATURE] Introduce Creation Wizards
- main 76662[FEATURE] Introduce global routes
- main 77679[WIP][FEATURE] Introduce ModifyRedirectServiceUriFromCustomLinkDetailsEvent
- main 75180[WIP][TASK] Introduce URL QueryParams models
- main 88260[TASK] Use native browser resizing for viewpage module
- main 67256[WIP][TASK] Enable TypeScript `strictNullChecks` option
- main 86821[WIP][TASK] Transform CSP PolicyRegistry into a request attribute
- main 85262[POC][TASK] Apply locale specific format to date/time fields
- main 68199[WIP][TASK] Add <typo3-backend-module> element
- main 80380[WIP][TASK] Sync navigation component context
Issues 1
Files 83
- Build/Sources/TypeScript/adminpanel/admin-panel.ts+24 −0
- Build/Sources/TypeScript/backend/preview/preview-frame.tsnew+353 −0
- Build/Sources/TypeScript/backend/preview/preview-page.tsnew+48 −0
- Build/Sources/TypeScript/backend/tests/preview/preview-frame-test.tsnew+491 −0
- Build/Sources/TypeScript/frontend/preview-navigation.tsnew+223 −0
- Build/Sources/TypeScript/viewpage/main.ts+5 −2
- Build/Sources/TypeScript/workspaces/tests/preview-test.tsnew+165 −0
- Build/Sources/TypeScript/workspaces/preview.ts+23 −4
- Build/tests/playwright/e2e/preview/preview-token.spec.tsnew+434 −0
- typo3/sysext/adminpanel/Classes/Modules/PreviewModule.php+16 −3
- typo3/sysext/adminpanel/Resources/Public/JavaScript/admin-panel.js+1 −1
- typo3/sysext/backend/Classes/ContextMenu/ItemProviders/PageProvider.php+1 −1
- typo3/sysext/backend/Classes/ContextMenu/ItemProviders/RecordProvider.php+1 −1
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+1 −1
- typo3/sysext/backend/Classes/Controller/PreviewPageController.phpnew+156 −0
- typo3/sysext/backend/Classes/Preview/AddressOutsidePreviewException.phpnew+26 −0
- typo3/sysext/backend/Classes/Preview/BackendLoginCookieScope.phpnew+78 −0
- typo3/sysext/backend/Classes/Preview/IssuedPreview.phpnew+38 −0
- typo3/sysext/backend/Classes/Preview/PreviewAccessDeniedException.phpnew+25 −0
- typo3/sysext/backend/Classes/Preview/PreviewTokenIssuer.phpnew+302 −0
Show 63 more files
- typo3/sysext/backend/Classes/Routing/PreviewUriBuilder.php+179 −1
- typo3/sysext/backend/Classes/Search/LiveSearch/DatabaseRecordProvider.php+1 −1
- typo3/sysext/backend/Classes/Search/LiveSearch/PageRecordProvider.php+1 −1
- typo3/sysext/backend/Configuration/Backend/AjaxRoutes.php+6 −0
- typo3/sysext/backend/Configuration/Backend/Routes.php+7 −0
- typo3/sysext/backend/Resources/Private/Language/preview.xlfnew+20 −0
- typo3/sysext/backend/Resources/Private/Templates/PreviewPage/Show.fluid.htmlnew+6 −0
- typo3/sysext/backend/Resources/Public/JavaScript/preview/preview-frame.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/preview/preview-page.jsnew+13 −0
- typo3/sysext/backend/Tests/Functional/Controller/PreviewPageControllerTest.phpnew+237 −0
- typo3/sysext/backend/Tests/Functional/Preview/Fixtures/sys_workspace.csvnew+3 −0
- typo3/sysext/backend/Tests/Functional/Preview/PreviewTokenIssuerTest.phpnew+795 −0
- typo3/sysext/backend/Tests/Functional/Routing/Fixtures/pages_backend_preview.csvnew+22 −0
- typo3/sysext/backend/Tests/Functional/Routing/PreviewUriBuilderBackendPreviewTest.phpnew+260 −0
- typo3/sysext/backend/Tests/Unit/Preview/BackendLoginCookieScopeTest.phpnew+99 −0
- typo3/sysext/core/Classes/Preview/PreviewGroupFilter.phpnew+146 −0
- typo3/sysext/core/Classes/Preview/PreviewHosts.phpnew+193 −0
- typo3/sysext/core/Classes/Preview/PreviewHostsResolver.phpnew+125 −0
- typo3/sysext/core/Classes/Preview/PreviewProfile.phpnew+135 −0
- typo3/sysext/core/Classes/Preview/PreviewRejection.phpnew+33 −0
- typo3/sysext/core/Classes/Preview/PreviewToken.phpnew+49 −0
- typo3/sysext/core/Classes/Preview/PreviewTokenRejectedException.phpnew+42 −0
- typo3/sysext/core/Classes/Preview/PreviewTokenService.phpnew+306 −0
- typo3/sysext/core/Documentation/Changelog/14.3.x/Important-110664-PreviewsOfHiddenPagesWorkOnEveryDomain.rstnew+350 −0
- typo3/sysext/core/Tests/Unit/Preview/PreviewHostsTest.phpnew+248 −0
- typo3/sysext/core/Tests/Unit/Preview/PreviewTokenServiceTest.phpnew+617 −0
- typo3/sysext/dashboard/Classes/Widgets/LatestChangedPagesWidget.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/FormViewHelper.php+98 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/FormViewHelperTest.php+166 −2
- typo3/sysext/frontend/Classes/Authentication/PreviewBackendUserAuthentication.phpnew+144 −0
- typo3/sysext/frontend/Classes/Authentication/PreviewBackendUserInitializer.phpnew+92 −0
- typo3/sysext/frontend/Classes/Authentication/PreviewDataHandlerGuard.phpnew+53 −0
- typo3/sysext/frontend/Classes/Middleware/BackendUserAuthenticator.php+5 −0
- typo3/sysext/frontend/Classes/Middleware/PreviewSimulator.php+86 −0
- typo3/sysext/frontend/Classes/Middleware/PreviewTokenAuthenticator.phpnew+391 −0
- typo3/sysext/frontend/Classes/Page/CacheHashCalculator.php+3 −2
- typo3/sysext/frontend/Classes/Preview/PreviewNavigationScript.phpnew+108 −0
- typo3/sysext/frontend/Classes/Preview/PreviewPageAccess.phpnew+76 −0
- typo3/sysext/frontend/Classes/Preview/PreviewRequestKind.phpnew+79 −0
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+13 −0
- typo3/sysext/frontend/Configuration/RequestMiddlewares.php+13 −0
- typo3/sysext/frontend/Resources/Private/Language/preview.xlfnew+30 −0
- typo3/sysext/frontend/Resources/Public/JavaScript/preview-navigation.jsnew+13 −0
- typo3/sysext/frontend/Tests/Functional/Authentication/PreviewBackendUserAuthenticationTest.phpnew+203 −0
- typo3/sysext/frontend/Tests/Functional/Middleware/PreviewTokenAuthenticatorCacheHashTest.phpnew+137 −0
- typo3/sysext/frontend/Tests/Functional/Middleware/PreviewTokenAuthenticatorContentSecurityPolicyTest.phpnew+454 −0
- typo3/sysext/frontend/Tests/Functional/Middleware/PreviewTokenAuthenticatorTest.phpnew+1564 −0
- typo3/sysext/frontend/Tests/Unit/Page/CacheHashCalculatorTest.php+17 −0
- typo3/sysext/frontend/Tests/Unit/Preview/PreviewRequestKindTest.phpnew+59 −0
- typo3/sysext/frontend/ext_localconf.php+5 −0
- typo3/sysext/redirects/Classes/Http/Middleware/RedirectHandler.php+9 −4
- typo3/sysext/redirects/Tests/Functional/Service/Fixtures/RedirectService_queryAsSent.csvnew+12 −0
- typo3/sysext/redirects/Tests/Functional/Service/RedirectServiceTest.php+68 −0
- typo3/sysext/viewpage/Classes/Controller/ViewModuleController.php+30 −11
- typo3/sysext/viewpage/Resources/Private/Templates/Show.fluid.html+1 −1
- typo3/sysext/viewpage/Resources/Public/JavaScript/main.js+1 −1
- typo3/sysext/viewpage/Tests/Functional/Controller/ViewModuleControllerTest.php+203 −2
- typo3/sysext/workspaces/Classes/Controller/PreviewController.php+64 −11
- typo3/sysext/workspaces/Classes/Middleware/WorkspacePreview.php+5 −0
- typo3/sysext/workspaces/Classes/Preview/PreviewUriBuilder.php+2 −2
- typo3/sysext/workspaces/Resources/Private/Templates/Preview/Index.fluid.html+2 −2
- typo3/sysext/workspaces/Resources/Public/JavaScript/preview.js+1 −1
- typo3/sysext/workspaces/Tests/Functional/Controller/PreviewControllerTest.php+237 −35
Review log 1833
Show 58 earlier messages
-
Matthias Vogel uploaded patch set 1 10/30/26, 10:54
-
core-ci voted on patch set 1 V -1 10/30/26, 11:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112855
-
Matthias Vogel uploaded patch set 2
V -110/30/26, 14:19 -
core-ci voted on patch set 2 V +1 10/30/26, 14:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112879
-
Oli Bartsch commented on patch set 2 10/31/26, 09:04
I would like to talk about this, to prevent introducing multiple different token solutions now. Check e.g. https://review.typo3.org/c/Packages/TYPO3.CMS/+/96561. -
Oli Bartsch commented on patch set 2 11/06/26, 08:24
Reply
still open -
Matthias Vogel uploaded patch set 3
V +111/09/26, 16:51 -
core-ci voted on patch set 3 V +1 11/09/26, 17:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113740
-
Matthias Vogel commented on patch set 3 11/10/26, 08:22
Reply
We discussed this, and the two concepts of tokens are different enough. -
Matthias Vogel uploaded patch set 4
V +111/10/26, 10:22 -
core-ci voted on patch set 4 V +1 11/10/26, 10:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113871
-
Matthias Vogel uploaded patch set 5
V +111/11/26, 17:52 -
core-ci voted on patch set 5 V -1 11/11/26, 18:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114134
-
core-ci commented on patch set 5 11/12/26, 09:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114134
-
Matthias Vogel uploaded patch set 6
V -111/12/26, 13:29 -
core-ci voted on patch set 6 V +1 11/12/26, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114187
-
Matthias Vogel uploaded patch set 7
V +111/12/26, 16:44 -
core-ci voted on patch set 7 V +1 11/12/26, 16:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114201
-
Matthias Vogel uploaded patch set 8
V +111/17/26, 13:55 -
Matthias Vogel commented on patch set 8 11/17/26, 13:55
Reading order for this change (patch set 8) 1. The token: PreviewTokenService signs and verifies it; PreviewToken and PreviewProfile are what it carries; PreviewHosts and PreviewHostsResolver resolve the hosts of the editor on every request (EXT:core, Classes/Preview). 2. The backend issues it: PreviewTokenIssuer, the preview page (EXT:backend PreviewPageController with the routes preview and preview_token), and PreviewUriBuilder::buildBackendPreviewUri() / buildBackendPreviewUriFor(), used by View, the Preview module and the workspace preview. 3. The frontend checks it: PreviewTokenAuthenticator (verify, authorize, applyProfile, respond; PreviewRequestKind names the kind of request), PreviewBackendUserInitializer and PreviewBackendUserAuthentication (the stateless editor), and PreviewSimulator, which calls PreviewPageAccess (page rights, groups) and PreviewNavigationScript (the navigation script). 4. The token travels: PageLinkBuilder, f:form (FormViewHelper), redirects (PreviewTokenAuthenticator::withTokenInLocation(), RedirectHandler), and the cHash exclusion. 5. The scripts: preview-frame.ts (backend page around the frame) and preview-navigation.ts (site); Playwright specs in Build/tests/playwright/e2e/preview. 6. The changelog entry Important-110664 says what extension authors and administrators have to check. -
core-ci voted on patch set 8 V +1 11/17/26, 14:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114739
-
Matthias Vogel uploaded patch set 9
V +111/18/26, 09:16 -
core-ci voted on patch set 9 V +1 11/18/26, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114837
-
Matthias Vogel uploaded patch set 10
V +111/18/26, 10:52 -
core-ci voted on patch set 10 V -1 11/18/26, 11:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114854
-
core-ci commented on patch set 10 11/18/26, 12:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114854
-
core-ci voted on patch set 10 V +1 11/18/26, 12:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114854
-
Matthias Vogel uploaded patch set 11
V +111/18/26, 12:52 -
core-ci voted on patch set 11 V +1 11/18/26, 13:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114876
-
Matthias Vogel marked it ready for review 11/18/26, 15:02
-
Matthias Vogel uploaded patch set 12
V +111/19/26, 09:38 -
core-ci voted on patch set 12 V +1 11/19/26, 09:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114988
-
Matthias Vogel marked it ready for review 11/19/26, 12:30