Review 13.4 Merged

88633[TASK] Use abstract docs.typo3.org linking service method

Georg Ringer CR +2 V +2 Easy +23 −10 updated 03/18/25, 07:32

Commit message

The DocumentationViewHelper contains logic to be able to link
to typo3.docs.org with specific versioning information. This
logic was not available to other areas in the PHP scope of
the core.

With this patch, this logic is put into the Typo3Information
DO, where other similar URLs are already listed.

This allows to have one central place to adjust documentation
URLs and the DocumentationViewHelper can now utilize this via:

```
$url = (new Typo3Information())
  ->getDocsLink('changelog:important-106192-1739862406');
```

(or using dependency injection)

As a drive-by, the URL_OPCACHE contents have been adjusted
and usage of existing instances is enforced.
Note that DI is not possible within the ViewHelper because
it is used in Install-Tool context that does not provide full DI.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 34

  1. Georg Ringer commented on patch set 1 03/18/25, 07:23

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 03/18/25, 07:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75757

  3. Georg Ringer voted on patch set 1 CR +2 V +2 03/18/25, 07:32

  4. Georg Ringer merged patch set 2 03/18/25, 07:32