Review 13.4 Merged

89780[BUGFIX] Allow language switch in "Open in new window" popup

Benjamin Franzke CR +2 V +2 Normal +104 −15 updated 06/23/25, 08:42

Commit message

Prevent JavaScript errors when switch languages
in FormEngine popup mode ("Open in new window").

The `<typo3-backend-module-router>` element is not available
in this mode, which is why the desired URL is assigned
to the frame directly.

Also sudo mode is adapted to avoid the workaround that has
been added in #106771, since @typo3/backend/viewport/content-container
is now handling this case.

This patch ensures the wanted location switch can be performed in
this case. An e2e test (playwright) is added to verify this.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 4

Files 5

Review log 34

  1. Benjamin Franzke commented on patch set 1 06/20/25, 13:02

    Cherry Picked from branch main.
  2. Benjamin Franzke voted on patch set 1 CR +2 V +2 06/20/25, 13:03

  3. core-ci voted on patch set 1 V +1 06/20/25, 13:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80533

  4. Benjamin Franzke merged patch set 2 06/23/25, 08:42