Review main Ready for review Stale

90550[BUGFIX] Use doktype of target page when checking for allowed record

Daniel Siepmann CR 0 V -1 Easy +2 −1 updated 06/18/26, 23:07

Commit message

The corresponding code code removed by accident during #106382 via
commit 9490df3126d5d7c6707296a6bbd6ef2a0b425da0.
This changed the logic to now check whether the record type would be
allowed on the record to insert.

Instead we now keep the old logic and determine the doktype of the
target page used to insert the record.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 2
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/50/90550/2 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/50/90550/2 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V -1 Blocked
    • core-ci -1 CI

Merge conflicts 13

Issues 1

Files 1

Review log 57

  1. Daniel Siepmann uploaded patch set 1 09/03/25, 05:41

  2. core-ci voted on patch set 1 V +1 09/03/25, 05:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84302

  3. Benni Mack commented on patch set 1 09/03/25, 08:10

    DataHandler.php:7439 Unresolved

    1. I cannot find this method in "main" anymore 2. Should we check if $pageRecord['doktype'] is set before doing the SQL query?
  4. Benni Mack wrote 04/21/26, 14:59

    Removed cc Benni Mack.
  5. Benni Mack updated the commit message in patch set 2 V +1 04/22/26, 06:51

  6. core-ci voted on patch set 2 V -1 04/22/26, 11:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100816

  7. Christian Kuhn wrote 06/18/26, 23:07

    Removed reviewer Christian Kuhn.