Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
90566[WIP][TASK] Warmup database cache listening to `CacheWarmupEvent`
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 17
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/66/90566/17 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/66/90566/17 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Relation chain 4
-
main
90957[WIP][!!!][TASK] Disable converting values by default in `Connection`
The chain has patch set 8 of 13, the changes above it need a rebase.
-
main
89293[BUGFIX] Honor parameter types in writable Connection methods
The chain has patch set 9 of 40, the changes above it need a rebase.
-
90566 [WIP][TASK] Warmup database cache listening to `CacheWarmupEvent` This change
-
main
90788[TASK] Avoid costly database schema queries and class state
The chain has patch set 15 of 16, the changes above it need a rebase.
Issues 7
- Task #107612Warmup database cache listening to `CacheWarmupEvent`
- Task #107611Avoid costly database schema queries and class state
- Task #107546Streamline `SchemaInformation` cache handling
- Bug #107406Revert "Avoid costly database schema queries and class state"
- Task #107390Avoid costly database schema queries and class state
- Feature #93436Command line cache warmup infrastructure
- Feature #99062Native JSON field support in Doctrine DBAL
Files 2
Review log 2946
Show 1321 earlier messages
-
Stefan Bürk uploaded patch set 1 09/04/25, 19:08
-
core-ci voted on patch set 1 V +1 09/04/25, 19:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84395
-
Stefan Bürk uploaded patch set 2
V +109/04/25, 19:22 -
core-ci voted on patch set 2 V +1 09/04/25, 19:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84396
-
Stefan Bürk uploaded patch set 3
V +109/04/25, 20:50 -
core-ci voted on patch set 3 V +1 09/04/25, 21:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84398
-
Stefan Bürk rebased onto patch set 4 09/05/25, 08:43
Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**") -
core-ci voted on patch set 4 V +1 09/05/25, 08:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84445
-
Stefan Bürk rebased onto patch set 5
V +109/05/25, 18:36 -
core-ci voted on patch set 5 V +1 09/05/25, 18:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84492
-
Stefan Bürk abandoned the change 09/06/25, 12:48
no need to add warmup, filesystem based cache needs to vanish due to multiple reasons and flaws -
Stefan Bürk restored the change 10/01/25, 08:36
-
Stefan Bürk marked it work in progress 10/01/25, 08:37
-
Stefan Bürk uploaded patch set 6
V +110/01/25, 08:37 -
core-ci voted on patch set 6 V +1 10/01/25, 08:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85791
-
Stefan Bürk uploaded patch set 7
V +110/01/25, 09:05 -
core-ci voted on patch set 7 V +1 10/01/25, 09:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85792
-
Stefan Bürk updated the commit message in patch set 8
V +110/01/25, 09:11 -
core-ci voted on patch set 8 V +1 10/01/25, 09:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85793
-
Stefan Bürk uploaded patch set 9
V +110/06/25, 14:27 -
Stefan Bürk marked it ready for review 10/06/25, 14:27
-
core-ci voted on patch set 9 V +1 10/06/25, 14:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86075
-
Stefan Bürk rebased onto patch set 10
V +110/07/25, 08:19 -
core-ci voted on patch set 10 V +1 10/07/25, 08:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86137
-
Stefan Bürk rebased onto patch set 11
V +110/07/25, 13:21 -
core-ci voted on patch set 11 V +1 10/07/25, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86164
-
Stefan Bürk rebased onto patch set 12
V +110/07/25, 17:39 -
core-ci voted on patch set 12 V +1 10/07/25, 17:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86175
-
Stefan Bürk rebased onto patch set 13
V +110/07/25, 17:52 -
core-ci voted on patch set 13 V +1 10/07/25, 18:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86178
-
Stefan Bürk rebased onto patch set 14
V +110/08/25, 10:08 -
core-ci voted on patch set 14 V +1 10/08/25, 10:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86218
-
Stefan Bürk uploaded patch set 15
V +110/08/25, 18:40 -
core-ci voted on patch set 15 V +1 10/08/25, 18:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86253
-
Christian Kuhn updated the commit message in patch set 16
V +110/09/25, 00:07 -
Christian Kuhn voted on patch set 16 CR +1 V +1 10/09/25, 00:07
-
core-ci voted on patch set 16 V +1 10/09/25, 00:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86259
-
Benjamin Franzke commented on patch set 16 10/09/25, 08:44
ConnectionPool.php:490Hm, `system` group was meant for file-sourced caches [1] and could be warmed up even if the system is not installed yet or databse was unavailable. This makes this group dependant on a working database connection. Would you mind adding a new group (like `db`?) for `database_schema` cache in order to allow developers to control which caches should be warmed up? An example where this could become problematic is: If a build server, that prepares a new release, runs `bin/typo3 cache:warmup -g system` it may not have access to the database and cache warmup would fail. (Disclaimer: I'm not aware of such setups, but it's theoretically possible if paths on build server and live server match) [1] https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/11.4/Feature-93436-IntroduceCacheWarmupConsoleCommand.html#:~:text=Note%20that%20file,with%20one%20release. -
Stefan Bürk commented on patch set 16 10/09/25, 10:03
ConnectionPool.php:490ReplyI get your point, and generally I have no objections not doing so. You pointed out possible deployment strategies where it may be a problem, and this is a serous point to discuss. The other side is, that currently the "database_schema" cache is already part of the `system` cache group, and a `bin/typo3 cache:flush -g system` would flush it, which is also part of deplyment strategies in pre-symlink changes (when using non-file cache backends, for example redis using release version based prefixes/container instances or similar). The need to flush the `db` cache now explicitly and **could** be felt as "breaking". So we may discuss further things how to proceed: * nail it down to main only and change cache group for `database_schema` ? * keep main & 13.4 and change cache group with a important restfile ? * keep main & 13.4 and keep the cache group definition, adding a important restfile lining out how to reconfigure the "cache group" for the "database_schema" cache and replace the TYPO3 EventListener to adjust the cache group check (hasGroup()`. Thinking about that ... would it not be better to check "hasGroup()" against the value(s) defined in the cache configuration for the `database_schema` cache, which would reduce required steps for instances to simple reconfigure the cache group and have it dedicated (splitting database_schema into dedicated db group). From my view there is no real good solution, but we need to find the "less-impacting/hurting" out of the "not so good" solutions. Not sure, need to think about it but wanted to share my thoughts on that first to allow others thinking about it with more information/arguments. -
Benni Mack commented on patch set 16 10/09/25, 13:51
ConnectionPool.php:490ReplyWell, I have similar concerns than bnf, but I got a more "funny" use-case / example: We use "cache:warmup" in CI, and on the prod machines, we use "extension:setup" to set up the new DB fields within the DB. We should at least document the best practice (or whatever practice you consider best) -
Christian Kuhn commented on patch set 16 10/09/25, 14:11
ConnectionPool.php:490Replyafaik there are more issues with 'warmup on different system, and deyloy warmed up caches stuff to live', for instance when absolute paths are written to cache files and staging lives on different paths. unsure if that is still the case with whatever we warmup currently, though. -
Stefan Bürk marked it work in progress 10/10/25, 09:47
-
Stefan Bürk updated the commit message in patch set 17
CR +1V +110/10/25, 09:47 -
Stefan Bürk commented on patch set 17 10/10/25, 09:51
ConnectionPool.php:490Reply UnresolvedPut change to WIP and restricted it to `main` only for now. There is no urgent need to backport this to 13.4, and in case some needs it it can be archieved with a dedicated extension implementing a listener. Based on the discussion and limiting it to main only we can move the `database_schema` cache to a dedicated cache group like `db` making this a `breaking` feature as it would target `cache:flush` also. Let's keep the change laying around for a couple of days so we can think about what to exactly do without pressure. Thanks to the insights and discussion arguments from all of you. -
core-ci voted on patch set 17 V +1 10/10/25, 09:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86377
-
Christian Kuhn wrote 06/18/26, 23:07
Removed reviewer Christian Kuhn.