91358[FEATURE] Introduce "Activity Stream" dasboard widget
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 15
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/58/91358/15 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/58/91358/15 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V -1 Blocked
- core-ci -1 CI
Relation chain 2
-
91358 [FEATURE] Introduce "Activity Stream" dasboard widget This change
-
main
92736[BUGFIX] Use "default" as default group
The chain has patch set 4 of 8, the changes above it need a rebase.
Merge conflicts 4
Issues 1
Files 12
- Build/Sources/Sass/dashboard/_widget_table.scss+20 −0
- Build/Sources/TypeScript/dashboard/widget/activity-stream-details-element.tsnew+95 −0
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-107918-ActivityStreamWidget.rstnew+37 −0
- typo3/sysext/dashboard/Classes/Widgets/Provider/ActivityStreamDataProvider.php6new+229 −0
- typo3/sysext/dashboard/Classes/Widgets/Provider/SysLogButtonProvider.php+9 −3
- typo3/sysext/dashboard/Classes/Widgets/ActivityStreamWidget.php2new+109 −0
- typo3/sysext/dashboard/Configuration/Services.yaml+20 −0
- typo3/sysext/dashboard/Documentation/Widgets/ActivityStreamWidget.rstnew+90 −0
- typo3/sysext/dashboard/Resources/Private/Language/locallang.xlf2+48 −0
- typo3/sysext/dashboard/Resources/Private/Templates/Widget/ActivityStreamWidget.html2new+110 −0
- typo3/sysext/dashboard/Resources/Public/Css/dashboard.css+3 −0
- typo3/sysext/dashboard/Resources/Public/JavaScript/widget/activity-stream-details-element.jsnew+13 −0
Review log 3348
Show 1423 earlier messages
-
Regis TEDONE uploaded patch set 1 10/30/25, 10:28
-
core-ci voted on patch set 1 V -1 10/30/25, 10:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88106
-
Regis TEDONE uploaded patch set 2
V -110/30/25, 11:36 -
core-ci voted on patch set 2 V -1 10/30/25, 12:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88126
-
Regis TEDONE uploaded patch set 3
V -110/30/25, 12:26 -
core-ci voted on patch set 3 V +1 10/30/25, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88134
-
Regis TEDONE uploaded patch set 4
V +110/30/25, 14:32 -
core-ci voted on patch set 4 V +1 10/30/25, 14:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88154
-
Regis TEDONE uploaded patch set 5
V +110/30/25, 15:05 -
core-ci voted on patch set 5 V +1 10/30/25, 15:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88158
-
Jasmina Ließmann commented on patch set 5 10/30/25, 16:34
Thank you for introducing the new widget! I have the following notes: - Currently, a lot of information is displayed as badges, which attracts too much attention. Perhaps the contents of the 'Type' and/or 'Action' columns could be displayed as normal text? - We don't normally have an 'Admin' badge below the admin name. This can be omitted. - The admin can slip into the role of a user – this is indicated, for example, in ‘History/Undo’ with the text ‘(via NAME-OF-THE-ADMIN-USERNAME)’. To keep it consistent, I would display this information in the same way.Feature-107918-ActivityStreamForAdminsWidget.rst:27When the widget is newly created, 10 entries are displayed. If you switch to the settings, it shows that only 5 entries should actually be displayed. This does not change even if you change and save one of the other settings. Only when you change the value in the ‘Number of entries to display’ field and save it, than the number of entries displayed change. Could the default setting in the actual display be set to 5? Or is the display in the select field faulty? -
Regis TEDONE uploaded patch set 6
V +110/31/25, 12:13 -
core-ci voted on patch set 6 V +1 10/31/25, 12:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88249
-
Regis TEDONE commented on patch set 6 10/31/25, 12:32
Feature-107918-ActivityStreamForAdminsWidget.rst:27ReplyThank you, Jasmina, for your constructive feedback. I have incorporated them into my latest patch. -
Oli Bartsch commented on patch set 6 10/31/25, 13:09
WidgetRegistry.php:36Please let's checkout all changes to this class. No additional permission option and also no added PHPDocs necessary.WidgetRegistry.php:43Widget Permissions are already configurable via "availableWidgets". I don't think we should add another static layer.ActivityStreamForAdminsWidget.php:250you could use `getQueryBuilderForTable` directlyActivityStreamForAdminsWidget.php:295I would like to question if we could replace all those pass by reference methods and instead return the processed data.ActivityStreamForAdminsWidget.rst:1This looks completely AI generated and must be reworked to just follow the usual documentation format. We also need a dedicated Feature RSTlocallang.xlf:272Let's check if we can reuse exiting labels. Most of this labels sound really generic.ActivityStreamForAdminsWidget.html:93We should use the <f:be.infobox> ViewHelper her. -
Regis TEDONE uploaded patch set 7
V +110/31/25, 13:28 -
core-ci voted on patch set 7 V +1 10/31/25, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88260
-
Regis TEDONE uploaded patch set 8
V +110/31/25, 14:54 -
Regis TEDONE commented on patch set 7 10/31/25, 14:54
Reply
DoneFeature-107918-ActivityStreamForAdminsWidget.rst:27ReplyDoneActivityStreamForAdminsWidget.php:250ReplyDoneActivityStreamForAdminsWidget.php:295ReplyI think that in enrichActivityInformation() if we iterate a normal foreach ($activities as $activity), call the helpers, then push the returned $activity into $processedActivities and return that. It will have a negligible performance impact but just a more conprehensive code maybe.ActivityStreamForAdminsWidget.rst:1ReplyDonelocallang.xlf:272ReplyDoneActivityStreamForAdminsWidget.html:93ReplyDone -
core-ci voted on patch set 8 V +1 10/31/25, 15:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88268
-
Simon Schaufelberger uploaded patch set 9
V +101/22/26, 22:15 -
Simon Schaufelberger commented on patch set 9 01/22/26, 22:16
@regis.tedone@gmail.com would you finish this one and take care about the comments from Oli to make this ready for v14? -
core-ci voted on patch set 9 V +1 01/22/26, 22:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94105
-
Stefan Bürk commented on patch set 9 01/23/26, 00:09
ActivityStreamForAdminsWidget.php:295Reply@regis.tedone@gmail.com I guess that olli did not talked about the foreach here. The methods, for example `enrichUserInformation()` should be changed from: ``` private function enrichUserInformation(array &$activity, array $userNames): void ``` to ``` private function enrichUserInformation(array $activity, array $userNames): array ``` and return the changed activity. And here in the loop replace L300 ``` $this->enrichUserInformation($activity, $userNames); ``` with ``` $activity = $this->enrichUserInformation($activity, $userNames); ``` and similar for `processDetailsField()`. But I may have misunderstood @bo@cedev.de too. Don't see the benefit of createing a new array. But could be also an option having for some time the duplicated memory used within the method scope. -
Juliane Wundermann uploaded patch set 10
V +102/02/26, 14:44 -
core-ci voted on patch set 10 V +1 02/02/26, 14:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94823
-
Juliane Wundermann commented on patch set 10 CR +1 V +1 02/02/26, 14:58
Reply
DoneWidgetRegistry.php:36ReplyDoneWidgetRegistry.php:43ReplyDoneActivityStreamForAdminsWidget.php:295ReplyDone -
Matthias Vogel voted on patch set 10 CR +1 V +1 02/05/26, 14:10
-
Oliver Hader commented on patch set 10 02/05/26, 18:21
Feature-107918-ActivityStreamForAdminsWidget.rst:32I guess the (internal) service registration can be dropped, can't it?Feature-107918-ActivityStreamForAdminsWidget.rst:62Does it mean, that this widget should only be visible to admin users?Feature-107918-ActivityStreamForAdminsWidget.rst:63I hope that following security best practices are followed in general. I guess this section can be dropped.Feature-107918-ActivityStreamForAdminsWidget.rst:65Section not relevant for features.Feature-107918-ActivityStreamForAdminsWidget.rst:71Section can be droppedFeature-107918-ActivityStreamForAdminsWidget.rst:76Section seems to be superfluous as wellActivityStreamForAdminsWidget.php:225In the rare case that there are no admin users, we directly might return an empty array - or continue the query with an falsified query like `userid IN (0)` (thus, setting `$adminUserIds = [0]`.ActivityStreamForAdminsWidget.php:238I'm not sure, which filter we should use here: * `error` (numeric), seems to be resolved from `\TYPO3\CMS\Core\SysLog\Error` * `level` (string), seems to be resolved from `\Psr\Log\LogLevel` In addition, we should use `createNamedParameter` consequently.ActivityStreamForAdminsWidget.php:375`mb_strlen` and `mb_substr`ActivityStreamForAdminsWidget.php:398Maybe with `JSON_UNESCAPED_SLASHES` for simpler URL representationActivityStreamForAdminsWidget.rst:5Section delimiters need to have same length as content -
Jasmina Ließmann wrote 02/05/26, 19:58
Removed cc Jasmina Ließmann. -
Matthias Vogel uploaded patch set 11
CR +1V +102/06/26, 12:46 -
core-ci voted on patch set 11 V +1 02/06/26, 12:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95285
-
Matthias Vogel uploaded patch set 12
V +102/06/26, 12:59 -
Matthias Vogel commented on patch set 11 02/06/26, 12:59
Feature-107918-ActivityStreamForAdminsWidget.rst:32ReplyDoneFeature-107918-ActivityStreamForAdminsWidget.rst:62ReplyDoneFeature-107918-ActivityStreamForAdminsWidget.rst:63ReplyDoneFeature-107918-ActivityStreamForAdminsWidget.rst:65ReplyDoneFeature-107918-ActivityStreamForAdminsWidget.rst:71ReplyDoneFeature-107918-ActivityStreamForAdminsWidget.rst:76ReplyDoneActivityStreamForAdminsWidget.php:225ReplyDoneActivityStreamForAdminsWidget.php:238ReplyDoneActivityStreamForAdminsWidget.php:375ReplyDoneActivityStreamForAdminsWidget.php:398ReplyDoneActivityStreamForAdminsWidget.rst:5ReplyDone -
Matthias Vogel voted on patch set 12 CR +1 V +1 02/06/26, 13:01
-
Oli Bartsch commented on patch set 12 V -1 02/06/26, 13:17
Feature-107918-ActivityStreamForAdminsWidget.rst:16This is not yet implementedActivityStreamForAdminsWidget.php:45This class is huge. Processing and data fetching should be moved to a widget data provider.ActivityStreamForAdminsWidget.rst:1I don't actually get this documentation. The widget is configured via TYPO3 an can be customized? However the example below does only show the default config. Can I use the options listed below in the config and if so how?ActivityStreamForAdminsWidget.html:100Widget should render a link to a "see all view" -
core-ci voted on patch set 12 V +1 02/06/26, 13:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95286
-
Oli Bartsch uploaded patch set 13
CR +1V +103/04/26, 21:36 -
core-ci voted on patch set 13 V +1 03/04/26, 21:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97366
-
Garvin Hicking commented on patch set 13 03/04/26, 21:49
ActivityStreamWidget.php:47Can this utilize the short domain language syntax here (I don't know)?ActivityStreamDataProvider.php:33I think this should be a widget config option too.ActivityStreamDataProvider.php:146Hm don't we have marker substitution in the actual sysLog viewing interface that we can re-use here all the argument replacing/parsing?ActivityStreamDataProvider.php:209Utilize language domain syntax hereActivityStreamWidget.html:14Language domain syntax here -
Oli Bartsch uploaded patch set 14
V +103/04/26, 22:54 -
Oli Bartsch commented on patch set 14 03/04/26, 22:55
Feature-107918-ActivityStreamForAdminsWidget.rst:16ReplyDoneFeature-107918-ActivityStreamForAdminsWidget.rst:16ReplyDoneActivityStreamForAdminsWidget.php:45ReplyDoneActivityStreamWidget.php:47ReplyDoneActivityStreamDataProvider.php:33ReplyNo this is a data provider setting and not changeable via UI.ActivityStreamDataProvider.php:146ReplyDoneActivityStreamDataProvider.php:209ReplyDoneActivityStreamForAdminsWidget.rst:1ReplyDoneActivityStreamForAdminsWidget.html:100ReplyDoneActivityStreamWidget.html:14ReplyDone -
core-ci voted on patch set 14 V +1 03/04/26, 23:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97369
-
Garvin Hicking commented on patch set 14 03/05/26, 07:50
Unresolved
Looking good. Since I can not adjust the length of error messages, I need to be able to inspect details of specific messages. Either I need a "show more" toggle, or I need a deep link into the sys_reports module to see the full message. -
Georg Ringer uploaded patch set 15
V +103/07/26, 07:13 -
Georg Ringer commented on patch set 15 03/07/26, 07:14
with help of AI I added some more stuff, maybe this goes in the right direction? what I don't like currently is that the list is different from the log module. widget: type + action module: level + channel this needs to be harmonized -
core-ci voted on patch set 15 V -1 03/07/26, 07:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97543
-
Soren Malling wrote 05/07/26, 09:54
Removed cc Soren Malling.