89309[BUGFIX] DataHandler commands move/copy: Always apply field updates
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 5
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/09/89309/5 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/09/89309/5 && git cherry-pick FETCH_HEAD
Review
-
Code review CR +1 Needs a vote
- Daniel Windloff +1
- Alexander Schnitzler +1
-
Verified V +1 Needs a vote
- Daniel Windloff +1
- Oliver Klee +1
- Alexander Schnitzler +1
- core-ci +1 CI
Merge conflicts 19
- main 97304[WIP][BUGFIX] Render the record form from unsaved values
- main 97560[TASK] Find subpages with one query when copying and deleting pages
- main 96740[BUGFIX] Respect columnsOverrides in inline localize sync
- main 97603[TASK] Introduce RecordTypeResolver and deprecate getTCAtypeValue()
- main 92429[BUGFIX] Keep tstamp of records whose sorting is only renumbered
- main 93819[WIP][BUGFIX] Guard translated tt_content free-mode moves
- main 94753[FEATURE] New TCA type "coordinate"
- main 96543[WIP][POC][TASK] Write and read records by the same rules and rights
- main 74781[FEATURE] Introduce new slug builders for records and string
- main 92859[WIP][BUGFIX] Make MM tables language-aware and workspace-aware
- main 95145[TASK] Migrate LanguageService->sL() labels to new domain syntax
- main 95343[FEATURE] Add `adminOnly` for TCA columns
- main 95638[TASK] Extend FieldValidationService to more TCA field types
- main 95639[TASK] Extract a read-only UniquenessChecker from DataHandler
- main 95637[TASK] Introduce FieldValidationService for TCA field validation
- main 93407[TASK] Modernize `RecordHistoryStore`
- main 92214[TASK] Introduce generic permission sets for accessing data
- main 85574[WIP][FEATURE] Language-aware slugs and slug normalizer API
- main 87719[WIP][BUGFIX] Mitigate missing column in cached schema information
Issues 1
Files 4
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+0 −1
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/MoveRecordMultiple.csvnew+3 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/CopyRecordTest.php+20 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/MoveActionTest.php+18 −0
Review log 1520
-
Thorben Nissen uploaded patch set 1 05/06/25, 10:03
-
core-ci voted on patch set 1 V +1 05/06/25, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78592
-
Stefan Bürk commented on patch set 1 05/07/25, 08:35
Change is declared as `bugfix`, but commit message states to remove something `superfluous`. When it is `superfluous` it has no impact, and removing it `cannot fix` something. Commit message and also the issue does not describe the bug or how it can be reproduced to verify the change (`bugfix aka fixing the bug`) against it. Otherwise it would be simply a task. Can you please describe the bug and a way to reproduce within the issue / commit message ? -
Stefan Bürk commented on patch set 1 05/07/25, 08:35
Reply
Unresolving the comment ;) -
Thorben Nissen updated the commit message in patch set 2
V +105/07/25, 08:47 -
Thorben Nissen commented on patch set 2 05/07/25, 08:49
@stefan@buerk.tech I updated the commit message. I hope, it is clearer now. -
core-ci voted on patch set 2 V +1 05/07/25, 08:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78627
-
Astrid Haubold commented on patch set 2 V +1 05/09/25, 11:29
Reply Unresolved
I reproduced the bug and described in the issue: when (for instance) copying several elements at once to a different column using DataHandler directly, only the last element gets the new colPos. But all elements should. -
Benni Mack commented on patch set 2 CR -1 07/24/25, 09:23
We need a functional test for this -
Benni Mack wrote 04/21/26, 15:00
Removed reviewer Benni Mack with the following votes: * Code-Review-1 by Benni Mack -
Benni Mack updated the commit message in patch set 3
V +104/22/26, 06:52 -
core-ci voted on patch set 3 V -1 04/22/26, 11:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100820
-
Christian Kuhn wrote 06/18/26, 23:04
Removed cc Christian Kuhn. -
Georg Ringer uploaded patch set 4
V -110/10/26, 07:48 -
core-ci voted on patch set 4 V +1 10/10/26, 08:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110762
-
Daniel Windloff updated the commit message in patch set 5
V +110/18/26, 12:06 -
Daniel Windloff voted on patch set 5 CR +1 V +1 10/18/26, 12:08
-
Oliver Klee voted on patch set 5 V +1 10/18/26, 12:08
-
core-ci voted on patch set 5 V +1 10/18/26, 12:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111517
-
Alexander Schnitzler commented on patch set 5 CR +1 V +1 10/18/26, 14:23
A Related: #89787 in the commit message would be nice.