Review main Ready for review Quiet

89309[BUGFIX] DataHandler commands move/copy: Always apply field updates

Thorben Nissen CR +1 V +1 Easy +41 −1 updated 10/18/26, 14:23

Commit message

The commands "copy" and "move" both have the option to update custom
field values of the copied or moved record as well.
Those updates now apply to all executed commands (not only the last executed one).

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 5
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/09/89309/5 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/09/89309/5 && git cherry-pick FETCH_HEAD

Review

  • Code review CR +1 Needs a vote
    • Daniel Windloff +1
    • Alexander Schnitzler +1
  • Verified V +1 Needs a vote
    • Daniel Windloff +1
    • Oliver Klee +1
    • Alexander Schnitzler +1
    • core-ci +1 CI

Merge conflicts 19

Issues 1

Files 4

Review log 1520

  1. Thorben Nissen uploaded patch set 1 05/06/25, 10:03

  2. core-ci voted on patch set 1 V +1 05/06/25, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78592

  3. Stefan Bürk commented on patch set 1 05/07/25, 08:35

    Change is declared as `bugfix`, but commit message states to remove something `superfluous`. When it is `superfluous` it has no impact, and removing it `cannot fix` something. Commit message and also the issue does not describe the bug or how it can be reproduced to verify the change (`bugfix aka fixing the bug`) against it. Otherwise it would be simply a task. Can you please describe the bug and a way to reproduce within the issue / commit message ?
  4. Stefan Bürk commented on patch set 1 05/07/25, 08:35

    Reply

    Unresolving the comment ;)
  5. Thorben Nissen updated the commit message in patch set 2 V +1 05/07/25, 08:47

  6. Thorben Nissen commented on patch set 2 05/07/25, 08:49

    @stefan@buerk.tech I updated the commit message. I hope, it is clearer now.
  7. core-ci voted on patch set 2 V +1 05/07/25, 08:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78627

  8. Astrid Haubold commented on patch set 2 V +1 05/09/25, 11:29

    Reply Unresolved

    I reproduced the bug and described in the issue: when (for instance) copying several elements at once to a different column using DataHandler directly, only the last element gets the new colPos. But all elements should.
  9. Benni Mack commented on patch set 2 CR -1 07/24/25, 09:23

    We need a functional test for this
  10. Benni Mack wrote 04/21/26, 15:00

    Removed reviewer Benni Mack with the following votes: * Code-Review-1 by Benni Mack
  11. Benni Mack updated the commit message in patch set 3 V +1 04/22/26, 06:52

  12. core-ci voted on patch set 3 V -1 04/22/26, 11:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100820

  13. Christian Kuhn wrote 06/18/26, 23:04

    Removed cc Christian Kuhn.
  14. Georg Ringer uploaded patch set 4 V -1 10/10/26, 07:48

  15. core-ci voted on patch set 4 V +1 10/10/26, 08:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110762

  16. Daniel Windloff updated the commit message in patch set 5 V +1 10/18/26, 12:06

  17. Daniel Windloff voted on patch set 5 CR +1 V +1 10/18/26, 12:08

  18. Oliver Klee voted on patch set 5 V +1 10/18/26, 12:08

  19. core-ci voted on patch set 5 V +1 10/18/26, 12:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111517

  20. Alexander Schnitzler commented on patch set 5 CR +1 V +1 10/18/26, 14:23

    A Related: #89787 in the commit message would be nice.