Review main Work in progress Quiet

92657[BUGFIX] Prevent duplicate inline children on concurrent localizations

Benni Mack CR 0 V -1 Normal +155 −5 updated 10/15/26, 22:37

Commit message

When triggering translations for multiple languages simultaneously
(e.g., clicking multiple language flags rapidly), inline child records
could be duplicated with incorrect l10n_parent relationships.

The root cause is a race condition in RelationHandler::readForeignField()
which queries child records by foreign_field without considering that
other concurrent localization operations may have already created
in-progress child records pointing to the same parent.

The fix sets the foreign_field to a negative value (-$uid) when
copying or localizing inline child records. This prevents concurrent
readForeignField() queries from finding these records since they query
with positive UIDs. The remap phase (writeForeignField) then updates
the field to the correct positive parent UID.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 3
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/57/92657/3 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/57/92657/3 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V -1 Blocked
    • core-ci -1 CI

Merge conflicts 13

Issues 1

Files 4

Review log 47

  1. Benni Mack uploaded patch set 1 02/04/26, 10:09

  2. core-ci voted on patch set 1 V -1 02/04/26, 10:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94994

  3. Tim Weisenberger uploaded patch set 2 V -1 04/23/26, 21:07

  4. core-ci voted on patch set 2 V -1 04/23/26, 21:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101055

  5. Tim Weisenberger updated the commit message in patch set 3 V -1 04/24/26, 06:55

  6. core-ci voted on patch set 3 V -1 04/24/26, 07:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101074

  7. Benni Mack wrote 10/15/26, 22:37

    Topic set to DataHandler