92777[BUGFIX] Restrict copied free-mode records to target languages
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 10
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/77/92777/10 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/77/92777/10 && git cherry-pick FETCH_HEAD
Review
-
Code review CR -1 Needs a vote
- André Buchmann +1
- Benni Mack -1
- Simon Schaufelberger +1
-
Verified V +1 Needs a vote
- André Buchmann +1
- Simon Schaufelberger +1
- core-ci +1 CI
Merge conflicts 12
- main 97304[WIP][BUGFIX] Render the record form from unsaved values
- main 97560[TASK] Find subpages with one query when copying and deleting pages
- main 97603[TASK] Introduce RecordTypeResolver and deprecate getTCAtypeValue()
- main 94753[FEATURE] New TCA type "coordinate"
- main 96543[WIP][POC][TASK] Write and read records by the same rules and rights
- main 74781[FEATURE] Introduce new slug builders for records and string
- main 95638[TASK] Extend FieldValidationService to more TCA field types
- main 95639[TASK] Extract a read-only UniquenessChecker from DataHandler
- main 93407[TASK] Modernize `RecordHistoryStore`
- main 92214[TASK] Introduce generic permission sets for accessing data
- main 85574[WIP][FEATURE] Language-aware slugs and slug normalizer API
- main 87719[WIP][BUGFIX] Mitigate missing column in cached schema information
Issues 1
Files 6
- typo3/sysext/core/Classes/DataHandling/DataHandler.php2+35 −1
- typo3/sysext/core/Tests/Functional/DataScenarios/RegularFreeMode/Modify/DataSet/copyFreeModeContentToPageWithoutTranslation.csvnew+35 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/RegularFreeMode/Modify/DataSet/copyFreeModeContentToPageWithTranslation.csvnew+37 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/RegularFreeMode/Modify/DataSet/copyFreeModeContentToSiteWithUnsupportedLanguage.csvnew+35 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/RegularFreeMode/Modify/ActionTest.php+44 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/RegularFreeMode/AbstractActionTestCase.php+17 −0
Review log 1727
Show 12 earlier messages
-
Eric Harrer uploaded patch set 1 02/10/26, 12:21
-
core-ci voted on patch set 1 V +1 02/10/26, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95540
-
Eric Harrer updated the commit message in patch set 2
V +102/10/26, 13:51 -
core-ci voted on patch set 2 V +1 02/10/26, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95549
-
Eric Harrer uploaded patch set 3
V +102/11/26, 08:36 -
core-ci voted on patch set 3 V +1 02/11/26, 09:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95603
-
Eric Harrer uploaded patch set 4
V +102/18/26, 07:27 -
Eric Harrer uploaded patch set 5 02/18/26, 07:30
-
core-ci voted on patch set 4 V -1 02/18/26, 07:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96103
-
core-ci voted on patch set 5 V -1 02/18/26, 07:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96104
-
Eric Harrer uploaded patch set 6
V -102/18/26, 07:49 -
core-ci voted on patch set 6 V -1 02/18/26, 07:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96105
-
Eric Harrer rebased onto patch set 7
V -102/18/26, 12:21 -
core-ci voted on patch set 7 V +1 02/18/26, 12:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96129
-
André Buchmann voted on patch set 7 CR +1 V +1 02/18/26, 15:58
-
André Buchmann uploaded patch set 8
CR +1V +102/25/26, 09:52 -
core-ci voted on patch set 8 V +1 02/25/26, 10:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96808
-
André Buchmann commented on patch set 8 CR +1 V +1 02/25/26, 10:08
Revote after rebase :-) -
Benni Mack updated the commit message in patch set 9
CR +1V +104/22/26, 06:42 -
core-ci voted on patch set 9 V -1 04/22/26, 11:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100766
-
Eric Harrer rebased onto patch set 10
V -104/23/26, 10:46 -
core-ci voted on patch set 10 V +1 04/23/26, 11:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101027
-
André Buchmann voted on patch set 10 CR +1 V +1 04/23/26, 21:13
-
Simon Schaufelberger voted on patch set 10 CR +1 V +1 06/23/26, 14:06
-
Benni Mack commented on patch set 10 07/17/26, 15:07
DataHandler.php:4227what's the reason for this change? -
André Buchmann commented on patch set 10 07/17/26, 21:34
DataHandler.php:4227Reply Unresolveddeduplication: in line 4189 the same exact ternary expression is used. we just reuse the result here. -
Benni Mack commented on patch set 10 CR -1 11/12/26, 19:32
Unresolved
Two issues with PS10: 1. The new tests copy uid 310, which is the default-language record, so they pass without the DataHandler change. Please copy the free-mode records 311/312 instead. 2. The check uses the source language, so a paste with update[sys_language_uid] (page module drag with copy) into a page without a translation in the source language is now refused, even when the target language is 0. Please use the effective target language. Also: requiring a page translation now refuses copying free-mode records inside storage folders and on pid 0. Is that intended, especially for 14.3?