Review main Ready for review

92777[BUGFIX] Restrict copied free-mode records to target languages

Eric Harrer CR -1 V +1 Normal +203 −1 updated 11/12/26, 19:32

Commit message

Restrict free-mode records to languages available in the target context
during copy operations.

Prevent creating free-mode records if
* the target site does not support the record language, or
* the target page does not have a translation in that language.

Preserve existing behavior for language-independent records and ensure
related child records are affected consistently by the restriction.

Tests are being adapted to cover copying free-mode records into target
contexts with limited or partial language availability.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 10
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/77/92777/10 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/77/92777/10 && git cherry-pick FETCH_HEAD

Review

  • Code review CR -1 Needs a vote
    • André Buchmann +1
    • Benni Mack -1
    • Simon Schaufelberger +1
  • Verified V +1 Needs a vote
    • André Buchmann +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Merge conflicts 12

Issues 1

Files 6

Review log 1727

Show 12 earlier messages
  1. Eric Harrer uploaded patch set 1 02/10/26, 12:21

  2. core-ci voted on patch set 1 V +1 02/10/26, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95540

  1. Eric Harrer updated the commit message in patch set 2 V +1 02/10/26, 13:51

  2. core-ci voted on patch set 2 V +1 02/10/26, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95549

  3. Eric Harrer uploaded patch set 3 V +1 02/11/26, 08:36

  4. core-ci voted on patch set 3 V +1 02/11/26, 09:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95603

  5. Eric Harrer uploaded patch set 4 V +1 02/18/26, 07:27

  6. Eric Harrer uploaded patch set 5 02/18/26, 07:30

  7. core-ci voted on patch set 4 V -1 02/18/26, 07:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96103

  8. core-ci voted on patch set 5 V -1 02/18/26, 07:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96104

  9. Eric Harrer uploaded patch set 6 V -1 02/18/26, 07:49

  10. core-ci voted on patch set 6 V -1 02/18/26, 07:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96105

  11. Eric Harrer rebased onto patch set 7 V -1 02/18/26, 12:21

  12. core-ci voted on patch set 7 V +1 02/18/26, 12:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96129

  13. André Buchmann voted on patch set 7 CR +1 V +1 02/18/26, 15:58

  14. André Buchmann uploaded patch set 8 CR +1 V +1 02/25/26, 09:52

  15. core-ci voted on patch set 8 V +1 02/25/26, 10:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96808

  16. André Buchmann commented on patch set 8 CR +1 V +1 02/25/26, 10:08

    Revote after rebase :-)
  17. Benni Mack updated the commit message in patch set 9 CR +1 V +1 04/22/26, 06:42

  18. core-ci voted on patch set 9 V -1 04/22/26, 11:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100766

  19. Eric Harrer rebased onto patch set 10 V -1 04/23/26, 10:46

  20. core-ci voted on patch set 10 V +1 04/23/26, 11:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101027

  21. André Buchmann voted on patch set 10 CR +1 V +1 04/23/26, 21:13

  22. Simon Schaufelberger voted on patch set 10 CR +1 V +1 06/23/26, 14:06

  23. Benni Mack commented on patch set 10 07/17/26, 15:07

    DataHandler.php:4227

    what's the reason for this change?
  24. André Buchmann commented on patch set 10 07/17/26, 21:34

    DataHandler.php:4227 Reply Unresolved

    deduplication: in line 4189 the same exact ternary expression is used. we just reuse the result here.
  25. Benni Mack commented on patch set 10 CR -1 11/12/26, 19:32

    Unresolved

    Two issues with PS10: 1. The new tests copy uid 310, which is the default-language record, so they pass without the DataHandler change. Please copy the free-mode records 311/312 instead. 2. The check uses the source language, so a paste with update[sys_language_uid] (page module drag with copy) into a page without a translation in the source language is now refused, even when the target language is 0. Please use the effective target language. Also: requiring a page translation now refuses copying free-mode records inside storage folders and on pid 0. Is that intended, especially for 14.3?