Review main Ready for review Orphaned

93307[TASK] Replace "OK" label in "Paste in clipboard content" modal

Riccardo De Contardi CR 0 V 0 Easy +28 −3 updated 04/22/26, 07:27

Commit message

For the "Paste in clipboard content" button in Media module
- replace "OK" on the modal with labels coherent with the actual
action performed; the same logic of
/sysext/filelist/Classes/ContextMenu/ItemProviders/FileProvider.php
has been applied
- Replace "Close" with "Cancel and use the new  language domain syntax

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 7
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/07/93307/7 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/07/93307/7 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote

Merge conflicts 5

Issues 1

Files 3

Review log 1017

  1. Riccardo De Contardi uploaded patch set 1 03/22/26, 17:39

  2. core-ci voted on patch set 1 V -1 03/22/26, 17:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98394

  3. Riccardo De Contardi commented on patch set 2 V -1 03/22/26, 18:00

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V +1 03/22/26, 18:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98395

  5. Garvin Hicking commented on patch set 2 CR -1 03/22/26, 19:21

    FileListController.php:695 Unresolved

    I think this is not a feature. Please uppercase first oetter of commit message. Please use new label syntax.
  6. Riccardo De Contardi updated the commit message in patch set 3 CR -1 V +1 03/22/26, 19:50

  7. Riccardo De Contardi updated the commit message in patch set 4 03/22/26, 19:57

  8. core-ci voted on patch set 3 V +1 03/22/26, 19:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98396

  9. core-ci voted on patch set 4 V -1 03/22/26, 20:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98397

  10. Riccardo De Contardi uploaded patch set 5 V -1 03/22/26, 20:28

  11. core-ci voted on patch set 5 V -1 03/22/26, 20:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98398

  12. Riccardo De Contardi uploaded patch set 6 V -1 03/22/26, 20:46

  13. core-ci voted on patch set 6 V -1 03/22/26, 20:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98399

  14. core-ci commented on patch set 6 03/22/26, 20:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98399

  15. Garvin Hicking commented on patch set 6 03/22/26, 21:02

    clipboard.xlf:2

    I think dirname should to be uppercase?
  16. Riccardo De Contardi commented on patch set 6 03/22/26, 21:09

    clipboard.xlf:2 Reply Unresolved

    I have seen already lowercase folders with the new syntax files, also on other patches. Which standard is the good one?
  17. Benni Mack updated the commit message in patch set 7 V -1 04/22/26, 07:27