Review 14.3 Merged

94796[BUGFIX] Prevent topbar button name duplication in firefox a11y tree

Benjamin Franzke CR +2 V +2 Easy +4 −5 updated 07/16/26, 12:29

Commit message

Firefox collects title attributes of DOM elements as
accessible names, even if their content is empty (or marked as
aria-hidden).

Since toolbar items contain icon wrapper markup that contains a title,
(which is needed for desktop mouse users, since the sibling text title
is visually hidden) and a title node as a text leaf, the title was read
out twice by screenreaders in firefox, since it's accessibility tree
collected the icon wrapper with the title as one generic node
and the text leaf as another node.

To unify browser behavior we're adding an explicit aria-hidden
attribute to the icon wrapper, in order for firefox to
interpret this DOM tree as other browser vendors do.

In addition the title attribute is removed from the search and single
clear-cache toolbar buttons in order to unify their behavior with the
other toolbar buttons which do only contain a title attribute on
the icon wrapper.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 34

  1. Benjamin Franzke commented on patch set 1 07/16/26, 06:40

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/16/26, 06:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104826

  3. Benjamin Franzke commented on patch set 1 CR +2 V +2 07/16/26, 12:29

    Confirmed on Firefox 152 again, "Clear cache Clear cache" becomes "Clear cache" and "Search Search" is now "Search" as expected.
  4. Benjamin Franzke merged patch set 2 07/16/26, 12:29