Review main Ready for review Stale

95142[BUGFIX] Align sys_file_metadata.color_space with ICC signatures

Marc Hirdes CR +1 V 0 Hard +332 −15 updated 08/10/26, 20:38

Commit message

Align predefined sys_file_metadata.color_space values with canonical ICC
signatures and remove incorrect legacy options from TCA.

Add upgrade wizard and functional test to migrate existing values:
- grey -> GRAY
- YUV -> YCbr
- sRGB -> RGB
- indx -> '' (empty value)

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 1
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/42/95142/1 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/42/95142/1 && git cherry-pick FETCH_HEAD

Review

  • Code review CR +1 Needs a vote
    • Andreas Wolf +1
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 4

Issues 1

Files 7

Review log 34

  1. Marc Hirdes uploaded patch set 1 08/06/26, 20:30

  2. core-ci voted on patch set 1 V +1 08/06/26, 20:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106049

  3. Andreas Wolf commented on patch set 1 CR +1 08/06/26, 21:00

    Important-109630-AlignSysFileMetadataColorSpaceWithIccSignatures.rst:15

    Might be good to have a link to a source for the values in this file.
  4. Garvin Hicking commented on patch set 1 08/10/26, 20:38

    Unresolved

    I think this is a breaking change? Consumers that relied on previous values when reading these may need updating. I think we need to have a Breaking-ReST changeolog entry for this.

    Important-109630-AlignSysFileMetadataColorSpaceWithIccSignatures.rst:15 Reply Unresolved