95142[BUGFIX] Align sys_file_metadata.color_space with ICC signatures
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 1
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/42/95142/1 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/42/95142/1 && git cherry-pick FETCH_HEAD
Review
-
Code review CR +1 Needs a vote
- Andreas Wolf +1
-
Verified V 0 Needs a vote
- core-ci +1 CI
Merge conflicts 4
Issues 1
Files 7
- typo3/sysext/core/Classes/Upgrades/SysFileMetadataColorSpaceMigration.phpnew+143 −0
- typo3/sysext/core/Documentation/Changelog/15.0/Important-109630-AlignSysFileMetadataColorSpaceWithIccSignatures.rst2new+33 −0
- typo3/sysext/core/Tests/Functional/Upgrades/Fixtures/SysFileMetadataColorSpaceMigrationAfter.csvnew+10 −0
- typo3/sysext/core/Tests/Functional/Upgrades/Fixtures/SysFileMetadataColorSpaceMigrationBefore.csvnew+10 −0
- typo3/sysext/core/Tests/Functional/Upgrades/SysFileMetadataColorSpaceMigrationTest.phpnew+49 −0
- typo3/sysext/filemetadata/Configuration/TCA/Overrides/sys_file_metadata.php+22 −4
- typo3/sysext/filemetadata/Resources/Private/Language/db.xlf+65 −11
Review log 34
-
Marc Hirdes uploaded patch set 1 08/06/26, 20:30
-
core-ci voted on patch set 1 V +1 08/06/26, 20:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106049
-
Andreas Wolf commented on patch set 1 CR +1 08/06/26, 21:00
-
Garvin Hicking commented on patch set 1 08/10/26, 20:38
Unresolved
I think this is a breaking change? Consumers that relied on previous values when reading these may need updating. I think we need to have a Breaking-ReST changeolog entry for this.Important-109630-AlignSysFileMetadataColorSpaceWithIccSignatures.rst:15Reply UnresolvedThat should be: https://archive.color.org/specification/ICC.1-2022-05.pdf?
Important-109630-AlignSysFileMetadataColorSpaceWithIccSignatures.rst:15