Review main Work in progress Quiet

95182[BUGFIX] Resolve file:current inside GIFBUILDER

Benjamin Kott CR 0 V 0 Normal +111 −7 updated 10/16/26, 14:05

Commit message

GIFBUILDER renders its TEXT and IMAGE objects through own
ContentObjectRenderer instances, since those operate on the data record
handed to GifBuilder::start() rather than on the record of the calling
content object. Those instances were created from scratch, so the file a
surrounding FILES content object had made "current" never arrived. A
"data = file:current:publicUrl" inside a GIFBUILDER therefore resolved
to nothing and the IMAGE object built from it was dropped, which left
LOAD_REGISTER as the only way to carry the file into the image.

The calling ContentObjectRenderer is now handed to the GifBuilder before
start(), and the current file is carried over to every
ContentObjectRenderer that GIFBUILDER creates, nested GIFBUILDER objects
included.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 1
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/82/95182/1 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/82/95182/1 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote

Merge conflicts 6

Issues 1

Files 3

Review log 3

  1. Benjamin Kott uploaded patch set 1 08/08/26, 22:44

  2. Benjamin Kott marked it work in progress 10/16/26, 14:05

  3. Benjamin Kott wrote 10/16/26, 14:05

    Unset private