95447[BUGFIX] Use translated option labels in form finisher output
Commit message
Review
-
Code review CR +2 Done
- Benjamin Kott +2
-
Verified V +2 Done
- Benjamin Kott +2
- core-ci +1 CI
Issues 3
Files 26
- Build/phpstan/phpstan-baseline.neon+0 −6
- typo3/sysext/core/Documentation/Changelog/14.3.x/Important-106903-FormElementValueResolutionInFinishers.rstnew+84 −0
- typo3/sysext/form/Classes/Domain/Finishers/AbstractFinisher.php+130 −31
- typo3/sysext/form/Classes/Domain/Finishers/ConfirmationFinisher.php+1 −1
- typo3/sysext/form/Classes/Domain/Finishers/EmailFinisher.php+7 −4
- typo3/sysext/form/Classes/Domain/Finishers/FlashMessageFinisher.php+2 −2
- typo3/sysext/form/Classes/Domain/Model/FormElements/CountrySelect.phpnew+35 −0
- typo3/sysext/form/Classes/Domain/Model/FormElements/Date.php+10 −1
- typo3/sysext/form/Classes/Domain/Model/FormElements/FileUpload.php+28 −1
- typo3/sysext/form/Classes/Domain/Model/FormElements/GenericOptionableFormElement.phpnew+53 −0
- typo3/sysext/form/Classes/Domain/Model/FormElements/ProcessableValueFormElementInterface.phpnew+31 −0
- typo3/sysext/form/Classes/Service/FormValueResolver.phpnew+111 −0
- typo3/sysext/form/Classes/ViewHelpers/RenderFormValueViewHelper.php+6 −107
- typo3/sysext/form/Configuration/Form/Base/FormElements/CountrySelect.yaml+1 −1
- typo3/sysext/form/Configuration/Form/Base/FormElements/MultiCheckbox.yaml+1 −1
- typo3/sysext/form/Configuration/Form/Base/FormElements/MultiSelect.yaml+1 −1
- typo3/sysext/form/Configuration/Form/Base/FormElements/RadioButton.yaml+1 −1
- typo3/sysext/form/Configuration/Form/Base/FormElements/SingleSelect.yaml+1 −1
- typo3/sysext/form/Tests/Functional/Domain/Finishers/EmailFinisherTest.php+199 −0
- typo3/sysext/form/Tests/Functional/Domain/Finishers/FlashMessageFinisherTest.phpnew+129 −0
Show 6 more files
- typo3/sysext/form/Tests/Functional/Domain/Finishers/SaveToDatabaseFinisherTest.php+131 −0
- typo3/sysext/form/Tests/Functional/ViewHelpers/RenderFormValueViewHelperTest.php+72 −1
- typo3/sysext/form/Tests/Unit/Domain/Finishers/Fixtures/AbstractFinisherFixture.php+5 −0
- typo3/sysext/form/Tests/Unit/Domain/Finishers/AbstractFinisherTest.php+90 −4
- typo3/sysext/form/Tests/Unit/Domain/Finishers/RedirectFinisherTest.php+77 −0
- typo3/sysext/form/Tests/Unit/Service/FormValueResolverTest.phpnew+146 −0
Review log 57
-
Benjamin Kott commented on patch set 1 08/27/26, 08:25
Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/form/Classes/ViewHelpers/RenderFormValueViewHelper.php * typo3/sysext/form/Tests/Functional/Domain/Finishers/EmailFinisherTest.php * typo3/sysext/form/Tests/Unit/Domain/Finishers/AbstractFinisherTest.php -
core-ci voted on patch set 1 V -1 08/27/26, 08:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107225
-
Benjamin Kott uploaded patch set 2
V -108/27/26, 08:38 -
Benjamin Kott commented on patch set 2 08/27/26, 08:38
This change is ready for review. -
core-ci voted on patch set 2 V +1 08/27/26, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107226
-
Benjamin Kott voted on patch set 2 CR +2 V +2 08/27/26, 09:01
-
Benjamin Kott merged patch set 3 08/27/26, 09:02