Review 14.3 Merged

95570[TASK] Allow record objects for record icons

Benni Mack CR +2 V +2 Normal +197 −9 updated 09/02/26, 17:13

Commit message

IconFactory->getIconForRecord() and the row argument of the Fluid
ViewHelper <core:iconForRecord> only accepted a plain database row
array. Code already working with record objects had to rebuild an
array just to render an icon.

IconFactory->getIconForRecordObject() now renders the icon for an
object implementing RecordInterface. The table is taken from the
record itself, the raw database row is used, so status overlays for
disabled or scheduled records are rendered the same way as for a
plain array.

The ViewHelper gained an interchangeable argument "record": both
"row" and "record" accept a row array as well as a record object,
exactly one of them must be given. The argument "table" is only
required for row arrays and is not evaluated for record objects.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 6

Review log 46

  1. Benni Mack commented on patch set 1 09/02/26, 15:59

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 09/02/26, 16:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107649

  3. Benni Mack commented on patch set 2 V -1 09/02/26, 16:56

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V +1 09/02/26, 17:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107663

  5. Benni Mack voted on patch set 2 CR +2 V +2 09/02/26, 17:13

  6. Benni Mack merged patch set 3 09/02/26, 17:13