95628[BUGFIX] Omit null attributes in media rendering
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
-
Verified V +2 Done
- Garvin Hicking +2
- core-ci +1 CI
Issues 2
Files 9
- typo3/sysext/core/Classes/Resource/Rendering/AudioTagRenderer.php+5 −1
- typo3/sysext/core/Classes/Resource/Rendering/VideoTagRenderer.php+5 −1
- typo3/sysext/core/Classes/Resource/Rendering/VimeoRenderer.php+4 −1
- typo3/sysext/core/Classes/Resource/Rendering/YouTubeRenderer.php+4 −1
- typo3/sysext/core/Documentation/Changelog/14.3.x/Important-95714-NullAttributesAreOmittedInMediaRendering.rstnew+48 −0
- typo3/sysext/core/Tests/Unit/Resource/Rendering/AudioTagRendererTest.php+5 −0
- typo3/sysext/core/Tests/Unit/Resource/Rendering/VideoTagRendererTest.php+5 −0
- typo3/sysext/core/Tests/Unit/Resource/Rendering/VimeoRendererTest.php+11 −0
- typo3/sysext/core/Tests/Unit/Resource/Rendering/YouTubeRendererTest.php+11 −0
Review log 46
-
Garvin Hicking commented on patch set 1 09/04/26, 06:48
Cherry Picked from branch main. -
Garvin Hicking commented on patch set 2 09/04/26, 06:49
Cherry Picked from branch main. -
core-ci voted on patch set 1 V -1 09/04/26, 07:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107811
-
core-ci voted on patch set 2 V +1 09/04/26, 07:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107813
-
Garvin Hicking voted on patch set 2 CR +2 V +2 09/04/26, 07:50
-
Garvin Hicking merged patch set 3 09/04/26, 07:50