Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress

95783[TASK] Provide the principal to the authorization checker

Thomas Maroschik CR 0 V -1 Normal +100 −8 updated 11/17/26, 19:05

Commit message

The authorization checker decides for the token in the token storage,
which nothing filled so far, so every check outside of tests was
denied. The backend and frontend user authentication middlewares now
put a PrincipalToken of the established principal into the token
storage while the request is handled, or no token for an anonymous
request.

Afterwards the token of an enclosing request is restored, so that
neither a sub request nor the next request handled by the same process
sees the principal of another request. The backend user of a frontend
request, used for preview and the admin panel, is no token of its own,
it is checked with isGrantedForUser().

The backend middleware also registers the backend user object for the
principal, so that module access gates receive it for decisions taken
on the token of the request.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 14
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/83/95783/14 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/83/95783/14 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V -1 Blocked
    • core-ci -1 CI

Relation chain 9

  1. main 97157[TASK] Decide module access with the authorization checker Based on this change Abandoned Benni Mack CR 0 V 0 Normal +84 −2
  2. main 95787[TASK] Deprecate auth services and addService('auth') Based on this change Abandoned Thomas Maroschik CR 0 V 0 unified-identity-security-kernel Normal +191 −0
  3. main 95786[FEATURE] Authenticate via AuthenticatorManager in user middlewares Based on this change Abandoned Thomas Maroschik CR 0 V 0 unified-identity-security-kernel Hard +370 −37
  4. main 95785[FEATURE] Register tagged authenticators and AuthenticatorManager Based on this change Abandoned Thomas Maroschik CR 0 V 0 unified-identity-security-kernel Hard +454 −0
  5. main 97323[TASK] Check page access along the cached page ancestry Based on this change Merge conflict Benni Mack CR 0 V 0 Normal +166 −1

    The chain has patch set 8 of 12, the changes above it need a rebase.

  6. main 97322[FEATURE] Decide page permissions with a security voter Based on this change Benni Mack CR 0 V 0 Expert +1489 −151

    The chain has patch set 8 of 12, the changes above it need a rebase.

  7. 95783 [TASK] Provide the principal to the authorization checker This change

  8. main 95784[FEATURE] Decide table, field and language access with voters This change is based on it Thomas Maroschik CR +1 V +1 unified-identity-security-kernel Expert +1215 −11

    The chain has patch set 15 of 19, the changes above it need a rebase.

  9. main 95781[FEATURE] Introduce security voters for authorization This change is based on it Merged Thomas Maroschik CR +2 V +2 unified-identity-security-kernel Nightmare +2715 −93

    The chain has patch set 15 of 19, the changes above it need a rebase.

Issues 3

Files 4

Review log 1630

Show 35 earlier messages
  1. Thomas Maroschik uploaded patch set 1 09/12/26, 08:29

  2. core-ci voted on patch set 1 V -1 09/12/26, 08:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108389

  3. Thomas Maroschik uploaded patch set 2 V -1 09/12/26, 09:04

  4. core-ci voted on patch set 2 V -1 09/12/26, 09:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108396

  5. Thomas Maroschik uploaded patch set 3 V -1 09/12/26, 11:36

  1. core-ci voted on patch set 3 V -1 09/12/26, 11:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108406

  2. Thomas Maroschik abandoned the change 10/22/26, 16:15

  3. Benni Mack restored the change 10/25/26, 14:19

  4. Benni Mack uploaded patch set 4 V -1 10/25/26, 14:19

  5. core-ci voted on patch set 4 V +1 10/25/26, 15:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112513

  6. Oli Bartsch uploaded patch set 5 V +1 10/25/26, 19:39

  7. core-ci voted on patch set 5 V +1 10/25/26, 20:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112543

  8. Benni Mack uploaded patch set 6 V +1 10/26/26, 19:41

  9. core-ci voted on patch set 6 V +1 10/26/26, 20:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112610

  10. Benni Mack rebased onto patch set 7 V +1 11/03/26, 14:43

  11. core-ci voted on patch set 7 V +1 11/03/26, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113166

  12. Benni Mack rebased onto patch set 8 V +1 11/09/26, 10:12

  13. core-ci voted on patch set 8 V +1 11/09/26, 10:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113642

  14. Benni Mack rebased onto patch set 9 V +1 11/10/26, 20:26

  15. core-ci voted on patch set 9 V +1 11/10/26, 21:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113949

  16. Benni Mack rebased onto patch set 10 V +1 11/13/26, 14:31

  17. core-ci voted on patch set 10 V +1 11/13/26, 16:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114341

  18. Benni Mack rebased onto patch set 11 V +1 11/13/26, 19:02

  19. core-ci voted on patch set 11 V +1 11/13/26, 20:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114377

  20. Benni Mack rebased onto patch set 12 V +1 11/13/26, 20:59

  21. core-ci voted on patch set 12 V +1 11/13/26, 22:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114399

  22. Benni Mack uploaded patch set 13 V +1 11/17/26, 15:48

  23. core-ci voted on patch set 13 V +1 11/17/26, 15:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114758

  24. Benni Mack uploaded patch set 14 V +1 11/17/26, 18:50

  25. core-ci voted on patch set 14 V -1 11/17/26, 19:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114781