Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
95867[FEATURE] Render pages without TypoScript
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 15
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/67/95867/15 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/67/95867/15 && git cherry-pick FETCH_HEAD
Review
-
Code review CR -2 Blocked
- Benni Mack -2
- Matthias Vogel +1
-
Verified V +1 Needs a vote
- Matthias Vogel +1
- core-ci +1 CI
Relation chain 3
- main 97001[TASK] Give custom package resource definitions precedence over defaults
-
95867 [FEATURE] Render pages without TypoScript This change
- main 96900[!!!][TASK] Apply site sets in the order a site declares them
Issues 1
Files 80
- typo3/sysext/core/Classes/Site/Set/ProjectSetProvider.phpnew+106 −0
- typo3/sysext/core/Classes/Site/Set/SetDefinition.php+5 −0
- typo3/sysext/core/Classes/Site/Set/SetRegistry.php+13 −2
- typo3/sysext/core/Classes/Site/Set/SetViewPathResolver.phpnew+118 −0
- typo3/sysext/core/Classes/Site/Set/SetViewRole.phpnew+29 −0
- typo3/sysext/core/Classes/Site/Set/SetViewScope.phpnew+26 −0
- typo3/sysext/core/Classes/Site/Set/YamlSetDefinitionProvider.php+2 −0
- typo3/sysext/core/Classes/TypoScript/FrontendTypoScriptFactory.php+13 −24
- typo3/sysext/core/Classes/TypoScript/PageObjectResolver.phpnew+179 −0
- typo3/sysext/core/Configuration/DefaultPackageResources.php+3 −0
- typo3/sysext/core/Documentation/Changelog/15.0/Feature-110716-PageRenderingWithoutTypoScript.rstnew+274 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_set_views/Configuration/Sets/Base/views/layouts/pages/default.fluid.htmlnew+1 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_set_views/Configuration/Sets/Base/views/layouts/default.fluid.htmlnew+1 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_set_views/Configuration/Sets/Base/views/pages/default.fluid.htmlnew+1 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_set_views/Configuration/Sets/Base/views/partials/pages/default.fluid.htmlnew+1 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_set_views/Configuration/Sets/Base/views/partials/default.fluid.htmlnew+1 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_set_views/Configuration/Sets/Base/config.yamlnew+2 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_set_views/Configuration/Sets/Dependent/views/layouts/default.fluid.htmlnew+1 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_set_views/Configuration/Sets/Dependent/views/pages/default.fluid.htmlnew+1 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_set_views/Configuration/Sets/Dependent/config.yamlnew+4 −0
Show 60 more files
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_set_views/Configuration/Sets/Invalid/config.yamlnew+3 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_set_views/Configuration/Sets/SiblingA/views/pages/default.fluid.htmlnew+1 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_set_views/Configuration/Sets/SiblingA/views/partials/default.fluid.htmlnew+1 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_set_views/Configuration/Sets/SiblingA/config.yamlnew+2 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_set_views/Configuration/Sets/SiblingB/views/pages/default.fluid.htmlnew+1 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_set_views/Configuration/Sets/SiblingB/config.yamlnew+2 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_set_views/Configuration/Sets/Silent/config.yamlnew+2 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_set_views/composer.jsonnew+18 −0
- typo3/sysext/core/Tests/Functional/Site/Set/ProjectSetTest.phpnew+263 −0
- typo3/sysext/core/Tests/Functional/Site/Set/SetViewPathResolverTest.phpnew+209 −0
- typo3/sysext/core/Tests/Unit/Site/Set/SetRegistryTest.php+3 −0
- typo3/sysext/core/Tests/Unit/TypoScript/PageObjectResolverTest.phpnew+269 −0
- typo3/sysext/frontend/Classes/ContentObject/PageViewContentObject.php+46 −12
- typo3/sysext/frontend/Classes/Middleware/PrepareTypoScriptFrontendRendering.php+11 −4
- typo3/sysext/frontend/Tests/Functional/ContentObject/PageViewContentObjectTest.php+32 −6
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_zero_typoscript/Configuration/Sets/ZeroTypoScript/views/layouts/default.fluid.htmlnew+1 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_zero_typoscript/Configuration/Sets/ZeroTypoScript/views/pages/default.fluid.htmlnew+6 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_zero_typoscript/Configuration/Sets/ZeroTypoScript/views/pages/standard.fluid.htmlnew+4 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_zero_typoscript/Configuration/Sets/ZeroTypoScript/config.yamlnew+2 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_zero_typoscript/Configuration/Sets/ZeroTypoScriptExplicitPageObject/config.yamlnew+4 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_zero_typoscript/Configuration/Sets/ZeroTypoScriptExplicitPageObject/setup.typoscriptnew+3 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_zero_typoscript/Configuration/Sets/ZeroTypoScriptOtherPageType/config.yamlnew+4 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_zero_typoscript/Configuration/Sets/ZeroTypoScriptOtherPageType/setup.typoscriptnew+6 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_zero_typoscript/Configuration/Sets/ZeroTypoScriptOverride/views/pages/default.fluid.htmlnew+5 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_zero_typoscript/Configuration/Sets/ZeroTypoScriptOverride/config.yamlnew+4 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_zero_typoscript/Configuration/Sets/ZeroTypoScriptPageIsTextObject/config.yamlnew+4 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_zero_typoscript/Configuration/Sets/ZeroTypoScriptPageIsTextObject/setup.typoscriptnew+2 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_zero_typoscript/Configuration/Sets/ZeroTypoScriptPageObjectNamedPage/config.yamlnew+4 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_zero_typoscript/Configuration/Sets/ZeroTypoScriptPageObjectNamedPage/setup.typoscriptnew+6 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_zero_typoscript/Configuration/Sets/ZeroTypoScriptPathsOutOfOrder/config.yamlnew+4 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_zero_typoscript/Configuration/Sets/ZeroTypoScriptPathsOutOfOrder/setup.typoscriptnew+3 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_zero_typoscript/Configuration/Sets/ZeroTypoScriptRoles/views/layouts/pages/default.fluid.htmlnew+1 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_zero_typoscript/Configuration/Sets/ZeroTypoScriptRoles/views/layouts/default.fluid.htmlnew+1 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_zero_typoscript/Configuration/Sets/ZeroTypoScriptRoles/views/pages/default.fluid.htmlnew+5 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_zero_typoscript/Configuration/Sets/ZeroTypoScriptRoles/views/partials/pages/header.fluid.htmlnew+1 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_zero_typoscript/Configuration/Sets/ZeroTypoScriptRoles/views/partials/footer.fluid.htmlnew+1 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_zero_typoscript/Configuration/Sets/ZeroTypoScriptRoles/views/partials/header.fluid.htmlnew+1 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_zero_typoscript/Configuration/Sets/ZeroTypoScriptRoles/config.yamlnew+2 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_zero_typoscript/Configuration/Sets/ZeroTypoScriptSiblingA/views/layouts/default.fluid.htmlnew+1 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_zero_typoscript/Configuration/Sets/ZeroTypoScriptSiblingA/views/pages/default.fluid.htmlnew+6 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_zero_typoscript/Configuration/Sets/ZeroTypoScriptSiblingA/config.yamlnew+2 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_zero_typoscript/Configuration/Sets/ZeroTypoScriptSiblingB/views/pages/default.fluid.htmlnew+5 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_zero_typoscript/Configuration/Sets/ZeroTypoScriptSiblingB/config.yamlnew+2 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_zero_typoscript/Configuration/Sets/ZeroTypoScriptTypoScriptOverride/config.yamlnew+4 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_zero_typoscript/Configuration/Sets/ZeroTypoScriptTypoScriptOverride/setup.typoscriptnew+1 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_zero_typoscript/Resources/Private/Templates/Layouts/Default.fluid.htmlnew+1 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_zero_typoscript/Resources/Private/Templates/Pages/Default.fluid.htmlnew+6 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_zero_typoscript/Resources/Private/TemplatesOverride/Pages/Default.fluid.htmlnew+5 −0
- typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_zero_typoscript/composer.jsonnew+18 −0
- typo3/sysext/frontend/Tests/Functional/Rendering/Fixtures/ZeroTypoScriptPages.csvnew+7 −0
- typo3/sysext/frontend/Tests/Functional/Rendering/PageViewSetRenderingTest.phpnew+374 −0
- typo3/sysext/frontend/Tests/Functional/Rendering/ProjectSetRenderingTest.phpnew+118 −0
- typo3/sysext/redirects/Tests/Unit/Service/RedirectServiceTest.php+4 −0
- typo3/sysext/tstemplate/Classes/Controller/ActiveTypoScriptController.php+3 −0
- typo3/sysext/tstemplate/Resources/Private/Language/locallang_active.xlf+6 −0
- typo3/sysext/tstemplate/Resources/Private/Templates/ActiveMain.fluid.html+9 −1
- typo3/sysext/tstemplate/Tests/Functional/Controller/Fixtures/be_users.csvnew+3 −0
- typo3/sysext/tstemplate/Tests/Functional/Controller/Fixtures/Pages.csvnew+3 −0
- typo3/sysext/tstemplate/Tests/Functional/Controller/ActiveTypoScriptControllerTest.phpnew+130 −0
- composer.json+1 −0
Review log 2136
Show 711 earlier messages
-
Oli Bartsch uploaded patch set 1 09/15/26, 21:49
-
core-ci voted on patch set 1 V -1 09/15/26, 21:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108642
-
Oli Bartsch uploaded patch set 2
V -109/15/26, 22:55 -
core-ci voted on patch set 2 V +1 09/15/26, 23:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108643
-
Georg Ringer voted on patch set 2 CR +1 V +1 09/16/26, 05:12
-
Benjamin Franzke commented on patch set 2 09/16/26, 06:10
Feature-110716-SiteSetTemplateRootPaths.rst:30I think we need to declare the `PAGEVIEW` object implicitly if at least one set uses the `pageViewPaths`/`templates` feature. Having to declare this dependency feels redundant and incorrect, given that the template path support is added as first class set configuration qualifier. -
Oli Bartsch uploaded patch set 3
CR +1V +109/16/26, 10:07 -
Oli Bartsch commented on patch set 3 09/16/26, 10:08
Feature-110716-SiteSetTemplateRootPaths.rst:22ReplyAgreed on all three points. Naming: pageViewPaths, so it says which templates it is about. Plural because template roots are an ordered list, like PAGEVIEW's own "paths.", so it takes a single path or a list. Zero configuration: a "pageview" directory next to config.yaml, found by name like labels.xlf and page.tsconfig, with lowercase pages/, layouts/ and partials/ as you sketched. Declared paths are optional and layer on top of it. Your drop-in point convinced me on a detail I had decided the other way before: a relative pageViewPaths value now resolves against the set, not the public directory, so a set never has to name its own extension key. One caveat towards real drop-ins: asset publishing runs per package, and which directories are public is declared in the extension's Configuration/Resources.php. A set's assets can be published from there, but the declaration lives outside the set and has to name its path, so a set still cannot bring CSS and JS along on its own. Probably worth a separate look, not something for this change.Feature-110716-SiteSetTemplateRootPaths.rst:30ReplyI actually had this in an earlier revision and dropped it again, because the obvious condition (no PAGE object anywhere in setup) breaks on core itself: EXT:seo declares "seo_sitemap = PAGE" with typeNum 1533906435, so adding the typo3/seo-sitemap set would kill type 0 rendering with "No page configured for type=0". Your formulation fixes that. The implicit object now applies when no PAGE object claims the *requested* type, which findPageObject() already determines, so a PAGE object of another type is irrelevant. It also bails out when "page" carries a value of its own ("page = TEXT"), and Active TypoScript shows an infobox that pages are rendered without a PAGE object, since the object itself is not listed anywhere. The typo3/page-view set is removed, it is redundant now. -
core-ci voted on patch set 3 V -1 09/16/26, 10:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108668
-
Oli Bartsch uploaded patch set 4
V -109/16/26, 11:05 -
core-ci voted on patch set 4 V +1 09/16/26, 11:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108674
-
Oli Bartsch commented on patch set 4 09/16/26, 13:26
Feature-110716-SiteSetTemplateRootPaths.rst:22Reply Unresolved.Feature-110716-SiteSetTemplateRootPaths.rst:30Reply Unresolved. -
Oli Bartsch uploaded patch set 5
V +109/16/26, 14:23 -
core-ci voted on patch set 5 V +1 09/16/26, 14:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108696
-
Oli Bartsch updated the commit message in patch set 6
V +109/18/26, 09:06 -
core-ci voted on patch set 6 V +1 09/18/26, 09:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108798
-
Oli Bartsch uploaded patch set 7
V +109/18/26, 10:41 -
core-ci voted on patch set 7 V +1 09/18/26, 10:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108801
-
Oli Bartsch uploaded patch set 8
V +110/19/26, 11:13 -
core-ci voted on patch set 8 V +1 10/19/26, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111622
-
Oli Bartsch uploaded patch set 9
V +110/19/26, 11:36 -
core-ci voted on patch set 9 V +1 10/19/26, 11:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111626
-
Oli Bartsch uploaded patch set 10
V +110/20/26, 07:30 -
core-ci voted on patch set 10 V +1 10/20/26, 07:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111751
-
Oli Bartsch uploaded patch set 11
V +110/20/26, 09:01 -
core-ci voted on patch set 11 V -1 10/20/26, 09:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111771
-
Oli Bartsch uploaded patch set 12
V -110/20/26, 09:31 -
core-ci voted on patch set 12 V +1 10/20/26, 09:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111779
-
Matthias Vogel uploaded patch set 13
V +110/22/26, 11:48 -
Matthias Vogel uploaded patch set 14 10/22/26, 11:58
-
core-ci voted on patch set 13 V -1 10/22/26, 12:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112097
-
core-ci voted on patch set 14 V -1 10/22/26, 12:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112100
-
Matthias Vogel uploaded patch set 15
V -110/22/26, 12:38 -
core-ci voted on patch set 15 V +1 10/22/26, 12:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112104
-
Matthias Vogel voted on patch set 15 CR +1 V +1 10/22/26, 12:58
-
Benni Mack commented on patch set 15 CR -2 10/23/26, 13:36
blocking until further notice (no offense)
Feature-110716-SiteSetTemplateRootPaths.rst:22