Review main Ready for review Quiet

97001[TASK] Give custom package resource definitions precedence over defaults

Matthias Vogel CR 0 V 0 Easy +43 −1 updated 10/22/26, 13:30

Commit message

Default package resource definitions are evaluated before custom
definitions from `Configuration/Resources.php`. Since resource lookup
returns the first matching definition, a default can mask an explicit
custom declaration.

For example, a package may explicitly declare public assets below
`Configuration/Sets`. The default private definition for site sets
otherwise matches first and prevents these assets from being published.

Evaluate custom definitions first so they take precedence over defaults.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 4
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/01/97001/4 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/01/97001/4 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Relation chain 3

  1. 97001 [TASK] Give custom package resource definitions precedence over defaults This change

  2. main 95867[FEATURE] Render pages without TypoScript This change is based on it Merge conflict Oli Bartsch CR -2 V +1 Expert +2427 −49
  3. main 96900[!!!][TASK] Apply site sets in the order a site declares them This change is based on it Merged Oli Bartsch CR +2 V +2 Normal +173 −29

Issues 1

Files 5

Review log 59

  1. Matthias Vogel uploaded patch set 1 10/22/26, 11:48

  2. Matthias Vogel rebased onto patch set 2 10/22/26, 11:58

  3. core-ci voted on patch set 1 V -1 10/22/26, 11:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112098

  4. core-ci voted on patch set 2 V -1 10/22/26, 12:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112101

  5. Matthias Vogel uploaded patch set 3 10/22/26, 12:36

    Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**")
  6. Matthias Vogel rebased onto patch set 4 V -1 10/22/26, 12:38

  7. core-ci voted on patch set 4 V +1 10/22/26, 12:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112105

  8. Matthias Vogel marked it ready for review 10/22/26, 12:53

  9. core-ci voted on patch set 3 V -1 10/22/26, 13:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112103