Review main Ready for review

96258[BUGFIX] Return type icon with title after visibility toggle

Georg Tiefenbrunn CR 0 V 0 Easy +16 −20 updated 11/10/26, 09:58

Commit message

The record visibility toggle re-read the record with only uid, pid
and the hidden field to render the icon for its AJAX response. The
type field was missing, so the icon fell back to the table default,
e.g. a "Text & Images" content element got the plain text icon, and
the icon had no title.

Read the full record and give the icon the same title the page
module and the records module render.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 2
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/58/96258/2 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/58/96258/2 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 8

Issues 3

Files 2

Review log 35

  1. Georg Tiefenbrunn uploaded patch set 1 10/01/26, 11:24

  2. core-ci voted on patch set 1 V +1 10/01/26, 11:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109788

  3. Benni Mack uploaded patch set 2 V +1 11/10/26, 09:48

  4. Benni Mack commented on patch set 2 11/10/26, 09:57

    Unresolved

    Hi Georg, thanks for the patch, sorry for not responding earlier. In the meantime the workspace half of this was fixed independently by https://review.typo3.org/c/Packages/TYPO3.CMS/+/97140 (#111234). It switched the re-read to getRecordWSOL() and added a test in RecordListControllerTest. I rebased your patch and kept only the part that's still missing on main: - read the full record so the icon picks up the type field (e.g. "Text & Images" no longer falls back to the plain text icon) - set the icon title like the page module and the records module do Since the workspace state is already covered, I dropped the separate test class and fixture. Could you check that PS2 still matches what you saw on your side?
  5. core-ci voted on patch set 2 V +1 11/10/26, 09:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113866