Review main Work in progress Quiet

96345[BUGFIX] Store MM relations to versioned records with the version uid

Georg Ringer CR 0 V 0 Normal +64 −1 updated 10/03/26, 06:34

Commit message

MM rows of records in a workspace point to the workspace uids on both
sides. When a relation to a record which already has a version in the
workspace is added from the other side, the MM row is written with the
live uid of that record instead of the uid of its version.

The version does not show the relation in the workspace, and once the
version gets published, its MM rows replace the ones of the live
record, so the relation is lost.

RelationHandler::convertItemArray() is meant to convert the submitted
ids to version ids, but skipped all workspace aware tables since the
switch to the Schema API, because the condition was inverted. This
affects select, group and category fields with MM relations.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 2
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/45/96345/2 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/45/96345/2 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 4

Issues 2

Files 3

Review log 24

  1. Georg Ringer uploaded patch set 1 10/03/26, 06:11

  2. core-ci voted on patch set 1 V -1 10/03/26, 06:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110026

  3. Georg Ringer uploaded patch set 2 V -1 10/03/26, 06:26

  4. core-ci voted on patch set 2 V +1 10/03/26, 06:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110028