Review main Work in progress Quiet

96342[BUGFIX] Keep MM relations when publishing one side in workspaces

Georg Ringer CR 0 V 0 Hard +488 −17 updated 10/03/26, 05:45

Commit message

When both records of an MM relation are modified in a workspace, the
workspace relation is stored between the two versions. Publishing only
one of them deleted all live MM rows of the record and moved the rows
of its version to the live uid, without checking if the record on the
opposite side is still an unpublished version.

As a result, the live relation was lost and live pointed to the
unpublished version instead. Discarding the other version removed the
relation for good.

On publish, live MM rows pointing to workspace records are now kept,
and a relation of the version to another unpublished version results
in a live relation to its live record, while the workspace keeps the
relation to the version.

Additionally, workspace records pointing to a published record keep
their reference index rows in their workspace instead of getting
orphaned rows in live.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 1
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/42/96342/1 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/42/96342/1 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 18

Issues 1

Files 9

Review log 12

  1. Georg Ringer uploaded patch set 1 10/03/26, 05:37

  2. core-ci voted on patch set 1 V +1 10/03/26, 05:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110022