Review 14.3 Merged

96403[TASK] Remove unnecessary ksort() in BackendLayoutWizardElement

Oli Bartsch CR +2 V +2 Easy +0 −3 updated 10/06/26, 11:10

Commit message

The spanned matrix row is sorted after it has been fully processed,
but it is never iterated again; lookups happen by key only. The
guarding "!== []" check is also always true, since rows are only
created by writing a value into them, which PHPStan 2.3 reports.

Remove the dead block.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Oli Bartsch commented on patch set 1 10/06/26, 08:07

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 10/06/26, 08:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110201

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 10/06/26, 11:10

  4. Oli Bartsch merged patch set 2 10/06/26, 11:10