Review 14.3 Merged

96489[TASK] Extract the extension scanner into a service

Benni Mack CR +2 V +2 Expert +1396 −190 updated 10/07/26, 19:11

Commit message

The extension scanner was only reachable through the install tool: the
scan loop lived inline in
UpgradeController::extensionScannerScanFileAction() and the 23 matchers
were a hardcoded property of the same controller, so no other caller,
such as a console command, could reuse them.

The matcher registry now lives in its own class, and scanning a file is
done by the new ExtensionScannerService, which returns typed results:
ScanResult per file, ScanMatch per finding and the Indicator enum,
backed by the existing values "strong" and "weak". The service also
finds the files to scan below a path. All of them are internal to
EXT:install.

UpgradeController delegates to the service, so the output of the
"Scan Extension Files" card is unchanged.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 2

Files 17

Review log 57

  1. Benni Mack commented on patch set 1 10/07/26, 15:32

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/install/Classes/Controller/UpgradeController.php * typo3/sysext/install/Classes/ServiceProvider.php
  2. core-ci voted on patch set 1 V -1 10/07/26, 17:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110365

  3. Benni Mack uploaded patch set 2 V -1 10/07/26, 18:41

  4. Benni Mack marked it ready for review 10/07/26, 18:41

  5. core-ci voted on patch set 2 V +1 10/07/26, 18:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110386

  6. Benni Mack voted on patch set 2 CR +2 V +2 10/07/26, 19:11

  7. Benni Mack merged patch set 3 10/07/26, 19:11