96489[TASK] Extract the extension scanner into a service
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
-
Verified V +2 Done
- Benni Mack +2
- core-ci +1 CI
Issues 2
Files 17
- typo3/sysext/install/Classes/Controller/UpgradeController.php+35 −189
- typo3/sysext/install/Classes/ExtensionScanner/Php/MatcherRegistry.phpnew+159 −0
- typo3/sysext/install/Classes/ExtensionScanner/Result/Indicator.phpnew+35 −0
- typo3/sysext/install/Classes/ExtensionScanner/Result/ScanMatch.phpnew+73 −0
- typo3/sysext/install/Classes/ExtensionScanner/Result/ScanResult.phpnew+81 −0
- typo3/sysext/install/Classes/ExtensionScanner/ExtensionScannerService.phpnew+228 −0
- typo3/sysext/install/Classes/ServiceProvider.php+11 −1
- typo3/sysext/install/Tests/Functional/Controller/UpgradeControllerTest.phpnew+260 −0
- typo3/sysext/install/Tests/Functional/UpgradeAnalysis/DocumentationFileTest.php+18 −0
- typo3/sysext/install/Tests/Unit/Controller/UpgradeControllerTest.php+72 −0
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Fixtures/BrokenSyntaxFixture.txtnew+5 −0
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Fixtures/IgnoredFileFixture.phpnew+31 −0
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Fixtures/RemovedFixtureClass.phpnew+24 −0
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Fixtures/ScanFixture.phpnew+35 −0
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/MatcherRegistryTest.phpnew+54 −0
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Result/ScanResultTest.phpnew+75 −0
- typo3/sysext/install/Tests/Unit/ExtensionScanner/ExtensionScannerServiceTest.phpnew+200 −0
Review log 57
-
Benni Mack commented on patch set 1 10/07/26, 15:32
Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/install/Classes/Controller/UpgradeController.php * typo3/sysext/install/Classes/ServiceProvider.php -
core-ci voted on patch set 1 V -1 10/07/26, 17:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110365
-
Benni Mack uploaded patch set 2
V -110/07/26, 18:41 -
Benni Mack marked it ready for review 10/07/26, 18:41
-
core-ci voted on patch set 2 V +1 10/07/26, 18:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110386
-
Benni Mack voted on patch set 2 CR +2 V +2 10/07/26, 19:11
-
Benni Mack merged patch set 3 10/07/26, 19:11