Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
96718[WIP] Add device preview with zoom and pan to the preview module
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 10
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/18/96718/10 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/18/96718/10 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Relation chain 4
- main 96720fix
-
96718 [WIP] Add device preview with zoom and pan to the preview module This change
- main 97236[FEATURE] Compare every preview with the live page
-
main
97235[BUGFIX] Preview hidden pages across site domains
The chain has patch set 4 of 12, the changes above it need a rebase.
Issues 2
Files 47
- Build/Sources/Sass/element/typo3-backend-device-preview-toolbar.scssnew+50 −0
- Build/Sources/Sass/element/typo3-backend-device-preview.scssnew+15 −0
- Build/Sources/Sass/element/typo3-viewpage-preview.scssnew+71 −0
- Build/Sources/Sass/module/_viewpage.scss+13 −104
- Build/Sources/Sass/backend.scss+3 −0
- Build/Sources/TypeScript/backend/device-preview/device-preview-element.tsnew+1160 −0
- Build/Sources/TypeScript/backend/device-preview/device-preview-navigation.tsnew+406 −0
- Build/Sources/TypeScript/backend/device-preview/device-preview-toolbar-element.tsnew+182 −0
- Build/Sources/TypeScript/backend/device-preview/zoom.tsnew+88 −0
- Build/Sources/TypeScript/backend/module/iframe.ts+11 −0
- Build/Sources/TypeScript/backend/tests/device-preview/device-preview-element-test.tsnew+954 −0
- Build/Sources/TypeScript/backend/tests/device-preview/device-preview-toolbar-element-test.tsnew+109 −0
- Build/Sources/TypeScript/backend/tests/device-preview/zoom-test.tsnew+96 −0
- Build/Sources/TypeScript/backend/tests/module-docheader-test.tsnew+58 −0
- Build/Sources/TypeScript/backend/module-docheader.ts+9 −0
- Build/Sources/TypeScript/viewpage/element/preview-element.tsnew+190 −0
- Build/Sources/TypeScript/viewpage/tests/frame-bridge-test.tsnew+116 −0
- Build/Sources/TypeScript/viewpage/tests/preview-element-test.tsnew+164 −0
- Build/Sources/TypeScript/viewpage/frame-bridge.tsnew+256 −0
- Build/Sources/TypeScript/viewpage/main.tsdeleted+0 −262
Show 27 more files
- Build/tests/playwright/e2e/preview/preview-access.spec.ts+2 −6
- Build/tests/playwright/e2e/preview/preview-module.spec.ts+668 −15
- typo3/sysext/backend/Resources/Private/Language/device_preview.xlfnew+35 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+18 −16
- typo3/sysext/backend/Resources/Public/JavaScript/device-preview/device-preview-element.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/device-preview/device-preview-navigation.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/device-preview/device-preview-toolbar-element.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/device-preview/zoom.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/module/iframe.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/module-docheader.js+1 −1
- typo3/sysext/core/Documentation/Changelog/15.0/Feature-111079-DevicePreviewWithZoomAndPanInThePreviewModule.rstnew+99 −0
- typo3/sysext/viewpage/Classes/Controller/ViewModuleController.php+220 −91
- typo3/sysext/viewpage/Classes/Middleware/FrameBridge.phpnew+93 −0
- typo3/sysext/viewpage/Configuration/page.tsconfig+0 −3
- typo3/sysext/viewpage/Configuration/RequestMiddlewares.phpnew+15 −0
- typo3/sysext/viewpage/Resources/Private/Language/locallang.xlf+38 −2
- typo3/sysext/viewpage/Resources/Private/Templates/Empty.fluid.htmldeleted+0 −12
- typo3/sysext/viewpage/Resources/Private/Templates/Show.fluid.html+40 −94
- typo3/sysext/viewpage/Resources/Public/JavaScript/element/preview-element.jsnew+13 −0
- typo3/sysext/viewpage/Resources/Public/JavaScript/frame-bridge.jsnew+13 −0
- typo3/sysext/viewpage/Resources/Public/JavaScript/main.jsdeleted+0 −13
- typo3/sysext/viewpage/Tests/Fixtures/be_users.csv+6 −2
- typo3/sysext/viewpage/Tests/Fixtures/pages_frame_bridge.csvnew+6 −0
- typo3/sysext/viewpage/Tests/Fixtures/pages_languages.csv+6 −5
- typo3/sysext/viewpage/Tests/Functional/Controller/ViewModuleControllerTest.php+270 −22
- typo3/sysext/viewpage/Tests/Functional/Middleware/FrameBridgeFrontendTest.phpnew+110 −0
- typo3/sysext/viewpage/Tests/Functional/Middleware/FrameBridgeTest.phpnew+134 −0
Review log 1121
-
Benjamin Kott uploaded patch set 1 10/15/26, 11:46
-
core-ci voted on patch set 1 V +1 10/15/26, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111187
-
Benjamin Franzke rebased onto patch set 2
V +110/15/26, 13:26 -
Benjamin Franzke rebased onto patch set 3 10/15/26, 13:39
-
core-ci voted on patch set 2 V -1 10/15/26, 13:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111194
-
core-ci voted on patch set 3 V +1 10/15/26, 13:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111199
-
Benjamin Kott rebased onto patch set 4
V +110/15/26, 15:57 -
core-ci voted on patch set 4 V +1 10/15/26, 16:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111221
-
Benjamin Kott marked it work in progress 10/16/26, 12:02
-
Benjamin Kott uploaded patch set 5
V +110/19/26, 16:34 -
core-ci voted on patch set 5 V +1 10/19/26, 16:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111680
-
Matthias Vogel uploaded patch set 6
V +110/26/26, 08:52 -
core-ci voted on patch set 6 V +1 10/26/26, 09:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112582
-
Matthias Vogel uploaded patch set 7
V +110/27/26, 10:30Follow navigation in the frame, keep a fitted screen in place, pan with the middle button - The frame keeps the preview on every navigation within the sites of the installation: links, forms, scripts and redirects, also to another site or language. Any other origin opens in a new window. - The module follows a navigation in the frame: the page tree selects the page, and the docheader, the title, the URL and the stored language follow. - The backend notices URL changes of a module by history.pushState() and replaceState(). - "Zoom to fit" with a width and a height keeps the whole screen in place, only the page scrolls. A screen that does not fit even at 10 % still pans. - A drag with the middle button pans also from within the page; a middle click on a link still opens it in a new tab. - Changelog, unit and e2e tests updated. -
core-ci voted on patch set 7 V +1 10/27/26, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112642
-
Matthias Vogel uploaded patch set 8
V +110/30/26, 14:19 -
core-ci voted on patch set 8 V +1 10/30/26, 14:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112881
-
Matthias Vogel uploaded patch set 9
V +111/09/26, 16:51 -
core-ci voted on patch set 9 V +1 11/09/26, 17:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113742
-
Matthias Vogel uploaded patch set 10
V +111/10/26, 10:22 -
core-ci voted on patch set 10 V +1 11/10/26, 10:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113873