Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
97236[FEATURE] Compare every preview with the live page
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 4
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/36/97236/4 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/36/97236/4 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Relation chain 3
- main 96718[WIP] Add device preview with zoom and pan to the preview module
-
97236 [FEATURE] Compare every preview with the live page This change
-
main
97235[BUGFIX] Preview hidden pages across site domains
The chain has patch set 4 of 12, the changes above it need a rebase.
Issues 1
Files 39
- Build/Sources/Sass/component/_preview.scssnew+102 −0
- Build/Sources/Sass/backend.scss+1 −0
- Build/Sources/Sass/workspace.scssdeleted+0 −134
- Build/Sources/TypeScript/backend/preview/preview-frame.ts+5 −0
- Build/Sources/TypeScript/backend/preview/preview-page.ts+93 −5
- Build/Sources/TypeScript/backend/preview/scroll-sync.tsnew+75 −0
- Build/Sources/TypeScript/frontend/preview-navigation.ts+64 −1
- Build/Sources/TypeScript/viewpage/main.ts+1 −4
- Build/Sources/TypeScript/workspaces/preview.ts+40 −101
- Build/tests/playwright/e2e/preview/preview-access.spec.ts+132 −10
- Build/tests/playwright/e2e/preview/preview-module.spec.ts+6 −9
- Build/Gruntfile.js+0 −5
- typo3/sysext/backend/Classes/Controller/Event/BeforePreviewPageRenderedEvent.phpnew+68 −0
- typo3/sysext/backend/Classes/Controller/PreviewController.php+93 −5
- typo3/sysext/backend/Classes/Preview/PreviewCompareModes.phpnew+71 −0
- typo3/sysext/backend/Resources/Private/Language/preview.xlf+50 −0
- typo3/sysext/backend/Resources/Private/Templates/Preview/Show.fluid.html+38 −4
- typo3/sysext/backend/Resources/Public/Css/backend.css+16 −0
- typo3/sysext/backend/Resources/Public/JavaScript/preview/preview-frame.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/preview/preview-page.js+1 −1
Show 19 more files
- typo3/sysext/backend/Resources/Public/JavaScript/preview/scroll-sync.jsnew+13 −0
- typo3/sysext/backend/Tests/Functional/Controller/PreviewControllerTest.php+21 −1
- typo3/sysext/backend/Tests/Unit/Preview/PreviewCompareModesTest.phpnew+82 −0
- typo3/sysext/core/Documentation/Changelog/15.0/Deprecation-111292-PageTSconfigWorkspacesSplitPreviewModes.rstnew+47 −0
- typo3/sysext/core/Documentation/Changelog/15.0/Feature-111292-CompareEveryPreviewWithTheLivePage.rstnew+89 −0
- typo3/sysext/frontend/Resources/Public/JavaScript/preview-navigation.js+1 −1
- typo3/sysext/viewpage/Classes/Controller/ViewModuleController.php+4 −24
- typo3/sysext/viewpage/Resources/Private/Templates/Show.fluid.html+1 −1
- typo3/sysext/viewpage/Resources/Public/JavaScript/main.js+1 −1
- typo3/sysext/workspaces/Classes/Controller/PreviewController.php+13 −184
- typo3/sysext/workspaces/Classes/EventListener/AddStageButtonsToPreviewPageListener.phpnew+37 −0
- typo3/sysext/workspaces/Classes/Hook/BackendUtilityHook.php+0 −33
- typo3/sysext/workspaces/Documentation/Administration/Configuration/Index.rst+8 −2
- typo3/sysext/workspaces/Resources/Private/Language/locallang.xlf+0 −24
- typo3/sysext/workspaces/Resources/Private/Templates/Preview/Index.fluid.htmldeleted+0 −65
- typo3/sysext/workspaces/Resources/Public/Css/preview.cssdeleted+0 −31
- typo3/sysext/workspaces/Resources/Public/JavaScript/preview.js+1 −1
- typo3/sysext/workspaces/Tests/Functional/Controller/Fixtures/new_page.csvnew+3 −0
- typo3/sysext/workspaces/Tests/Functional/Controller/PreviewControllerTest.php+70 −50
Review log 48
-
Matthias Vogel uploaded patch set 1 10/30/26, 10:54
-
core-ci voted on patch set 1 V -1 10/30/26, 11:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112856
-
Matthias Vogel uploaded patch set 2
V -110/30/26, 14:19 -
core-ci voted on patch set 2 V +1 10/30/26, 14:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112880
-
Matthias Vogel uploaded patch set 3
V +111/09/26, 16:51 -
core-ci voted on patch set 3 V +1 11/09/26, 17:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113741
-
Matthias Vogel uploaded patch set 4
V +111/10/26, 10:22 -
core-ci voted on patch set 4 V +1 11/10/26, 10:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113872