Review main Ready for review

96749[FEATURE] Select and sort columns in redirects module

Benni Mack CR -1 V +1 Hard +875 −110 updated 11/19/26, 13:09

Commit message

The redirects module showed a fixed set of columns. It now offers
the "Show columns" modal known from the Records and Media modules.

The source, combining host and path, and the target are always
shown. Without a selection, the list shows the same columns as
before. Further fields are only offered if the user has access to
them, which includes fields added to sys_redirect by extensions.

Every column holding a plain value can now be used for sorting. The
allowed sort fields are derived from the available columns, so
fields the user has no access to cannot be used for ordering. The
uid is added as last sort criterion to keep the pagination stable
for columns with many equal values.

DatabaseRecordList is not used for this, since it limits queries to
pages and derives permissions from the parent page, while redirects
are listed across all pages and checked by RedirectPermissionGuard.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 4
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/49/96749/4 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/49/96749/4 && git cherry-pick FETCH_HEAD

Review

  • Code review CR -1 Needs a vote
    • Oli Bartsch -1
    • Simon Schaufelberger +1
  • Verified V +1 Needs a vote
    • Simon Schaufelberger +1
    • core-ci +1 CI

Merge conflicts 9

Issues 2

Files 11

Review log 711

  1. Benni Mack uploaded patch set 1 10/16/26, 09:33

  2. core-ci voted on patch set 1 V +1 10/16/26, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111344

  3. Benni Mack uploaded patch set 2 V +1 11/11/26, 14:20

  4. Benni Mack uploaded patch set 3 11/11/26, 14:26

  5. core-ci voted on patch set 2 V +1 11/11/26, 14:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114097

  6. core-ci voted on patch set 3 V +1 11/11/26, 14:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114098

  7. Benni Mack uploaded patch set 4 V +1 11/13/26, 10:25

  8. Benni Mack marked it ready for review 11/13/26, 10:26

  9. core-ci voted on patch set 4 V +1 11/13/26, 10:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114303

  10. Simon Schaufelberger voted on patch set 4 CR +1 V +1 11/13/26, 22:43

  11. Oli Bartsch commented on patch set 4 CR -1 11/19/26, 13:09

    Unresolved

    Needs to be checked in detail.