97122[TASK] Restore time zones after date tests
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 2
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/22/97122/2 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/22/97122/2 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Merge conflicts 9
- main 97603[TASK] Introduce RecordTypeResolver and deprecate getTCAtypeValue()
- main 96341[BUGFIX] Validation of TCA column type "color"
- main 94753[FEATURE] New TCA type "coordinate"
- main 96543[WIP][POC][TASK] Write and read records by the same rules and rights
- main 74781[FEATURE] Introduce new slug builders for records and string
- main 95638[TASK] Extend FieldValidationService to more TCA field types
- main 95637[TASK] Introduce FieldValidationService for TCA field validation
- main 86432[WIP][TASK] Cache flexform schema during TCA schema creation
- main 85262[POC][TASK] Apply locale specific format to date/time fields
Issues 1
Files 3
Review log 78
-
Wouter Wolters uploaded patch set 1 10/25/26, 09:08
-
Wouter Wolters updated the commit message in patch set 2 10/26/26, 20:51
-
Wouter Wolters marked it ready for review 10/26/26, 20:51
-
Wouter Wolters wrote 10/26/26, 20:51
Unset private -
core-ci voted on patch set 2 V +1 10/26/26, 21:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112612
-
Oliver Klee commented on patch set 2 10/26/26, 21:08
AbstractFormElementTest.php:285To clearly separate concerns and to ansure the time zone configuration is restores, the backup should go into `setUp()` and the restore into `tearDown()`. -
Wouter Wolters commented on patch set 2 10/26/26, 21:18
AbstractFormElementTest.php:285ReplyTYPO3 explicitly forbids #[WithoutErrorHandler] in PHPStan configuration (Build/phpstan/phpstan.neon:16) -
Wouter Wolters commented on patch set 2 10/26/26, 21:20
AbstractFormElementTest.php:285Reply UnresolvedMixed this comment, with your other question in another patch of mine. Had 2 windows open. I explicitly did it this way because we only have one test. Instead of resetting it for each test.