Review 14.3 Merged

97303[BUGFIX] Reject non-string dumpFile tokens with 403

Garvin Hicking CR +2 V +2 Normal +128 −1 updated 11/02/26, 17:30

Commit message

FileDumpController passed the token query parameter unchecked to
`hash_equals()`, so `&token[]=x` caused a TypeError and an HTTP 500
status code.

Non-string tokens are now treated as invalid, tests ensure the
behavior.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Garvin Hicking commented on patch set 1 11/02/26, 17:15

    Cherry Picked from branch main.
  2. Garvin Hicking commented on patch set 2 11/02/26, 17:16

    Published edit on patch set 1.
  3. core-ci voted on patch set 2 V +1 11/02/26, 17:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113098

  4. Garvin Hicking voted on patch set 2 CR +2 V +2 11/02/26, 17:29

  5. Garvin Hicking merged patch set 3 11/02/26, 17:30